Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: semver and releases #236

Merged
merged 15 commits into from
Jun 27, 2024
Merged

CI: semver and releases #236

merged 15 commits into from
Jun 27, 2024

Conversation

JustSamuel
Copy link
Contributor

Description

The goal of this PR is to create automagic versioned releases of the monorepo and its libraries. They will be released in the form of {{app}}:{{monorepo version}}. The releases will be atomically done when merging into main based on sementic-release commits analyzer:

(Squashed) PRs with commits containing:

  • fix: will cause a patch release
  • feat: will cause a feature release (minor)
  • BREAKING CHANGE: will cause a major release

Related issues/external references

none afaik.

Types of changes

  • CI/CD (Changes to the CI/CD configuration)

@JustSamuel JustSamuel changed the title CI: semver and releases [DRAFT-ISH] CI: semver and releases Jun 25, 2024
@JustSamuel JustSamuel changed the title [DRAFT-ISH] CI: semver and releases CI: semver and releases Jun 26, 2024
@JustSamuel JustSamuel requested a review from SuperVK June 26, 2024 13:52
@SuperVK
Copy link
Member

SuperVK commented Jun 26, 2024

If I read the yaml's correctly, the docker image ci run and push to pkg.gewis.nl on pushing to main. Now with the fast-forward this should not trigger, but if we do want to push it will trigger and still push to main tag on docker. Is this intended?

@JustSamuel
Copy link
Contributor Author

JustSamuel commented Jun 26, 2024

If I read the yaml's correctly, the docker image ci run and push to pkg.gewis.nl on pushing to main. Now with the fast-forward this should not trigger, but if we do want to push it will trigger and still push to main tag on docker. Is this intended?

Yes, in this construction we will also have a rolling main, develop, sudopos-ab (which is develop)

You can decide to not do it, but since not every push releases a version it might be nice to have a "always latest of the branch". I.e someone did a wrong commit (ci but actually contained a bugfix( which can then be instant deployed if needed.

.releaserc.json Outdated Show resolved Hide resolved
Copy link
Member

@rinkp rinkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested the GH actions, but i am in favor of this idea.

Please note that you are renaming an action that is mandatory for PRs so upon merging this, please update the branch protection rules accordingly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that you are renaming an action that is mandatory for PRs so upon merging this, please update the branch protection rules accordingly

Copy link
Member

@SuperVK SuperVK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets test it!

@JustSamuel JustSamuel merged commit 15af1e6 into develop Jun 27, 2024
3 checks passed
@JustSamuel JustSamuel deleted the feature/semver branch June 27, 2024 18:19
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants