-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: semver and releases #236
Conversation
454442d
to
ffe7b30
Compare
ffe7b30
to
9fe7840
Compare
b6e1594
to
3756e35
Compare
35f2d67
to
dc5ff8b
Compare
If I read the yaml's correctly, the docker image ci run and push to pkg.gewis.nl on pushing to main. Now with the fast-forward this should not trigger, but if we do want to push it will trigger and still push to main tag on docker. Is this intended? |
Yes, in this construction we will also have a rolling main, develop, sudopos-ab (which is develop) You can decide to not do it, but since not every push releases a version it might be nice to have a "always latest of the branch". I.e someone did a wrong commit (ci but actually contained a bugfix( which can then be instant deployed if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tested the GH actions, but i am in favor of this idea.
Please note that you are renaming an action that is mandatory for PRs so upon merging this, please update the branch protection rules accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that you are renaming an action that is mandatory for PRs so upon merging this, please update the branch protection rules accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets test it!
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
The goal of this PR is to create automagic versioned releases of the monorepo and its libraries. They will be released in the form of
{{app}}:{{monorepo version}}
. The releases will be atomically done when merging into main based onsementic-release
commits analyzer:(Squashed) PRs with commits containing:
fix
: will cause a patch releasefeat
: will cause a feature release (minor)BREAKING CHANGE
: will cause a major releaseRelated issues/external references
none afaik.
Types of changes