Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor mailing tempalte to be in the GEWIS STIJL #156

Closed
JustSamuel opened this issue Feb 15, 2024 · 1 comment · Fixed by #236
Closed

Refactor mailing tempalte to be in the GEWIS STIJL #156

JustSamuel opened this issue Feb 15, 2024 · 1 comment · Fixed by #236

Comments

@JustSamuel
Copy link
Contributor

Based on @rinkp his remark on this issue. It might be nice to change the mailing theme.

@rinkp
Copy link
Member

rinkp commented Mar 18, 2024

When implementing this, it is vital not to change any items in the output. It is known that there are redundant divs, that a lot of styling is applied directly to items instead of classes, and that there is a bunch of extra CSS.
The reason is that emails are hard to work with, and there are a lot of different email clients.
The current styles have been verified to work in Thunderbird (Windows/Linux), Outlook (Windows, Android), and GMail (Web/Android/iOS) 's light and dark modes. Additionally, they have been tested with the Google and Microsoft spamfilters and common defaults for rspamd and SpamAssassin to make sure they are not marked as spam.

Guidelines for usage: don´t include too much HTML in the yaml, don´t make fake hrefs (wrong: <a href="https://gewis.nl/super-long-url">gew.is/short</a>, correct: <a href="https://gew.is/short">https://gew.is/short</a>, also correct: <a href="https://gewis.nl/super-long-url">click here</a>, and be careful with including images.

@rinkp rinkp added the good first issue good first issue label Mar 18, 2024
@Yoronex Yoronex linked a pull request Jul 29, 2024 that will close this issue
@Yoronex Yoronex self-assigned this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants