Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: sort room filters like on the official website #88

Open
jtanguy opened this issue Oct 17, 2022 · 5 comments
Open

Feature: sort room filters like on the official website #88

jtanguy opened this issue Oct 17, 2022 · 5 comments
Assignees
Labels
enhancement Enhancement of existing feature ios iOS app shared module Shared module

Comments

@jtanguy
Copy link

jtanguy commented Oct 17, 2022

It seems that the room filters are sorted alphabetically, instead of the order presented on the website (it seems that they are ordered by capacity, but I'm not sure).
It I'll be easier to use the room filters (the big room first instead of third)

Screenshot_20221017-142300.jpg

@RobinCaroff
Copy link
Collaborator

@jtanguy Thanks for submitting the issue! Good thinking, it would make more sens indeed.

We cannot automatically deduce the importance of the rooms from the data provided by the DevFest Nantes's repo(https://github.com/GDG-Nantes/Devfest2022/tree/master/data) and we would need this info to setup sorting on our backend side.

I'll keep this issue opened as I'm sure we can do this for next year.

@RobinCaroff RobinCaroff added enhancement Enhancement of existing feature shared module Shared module labels Oct 17, 2022
@jtanguy
Copy link
Author

jtanguy commented Oct 17, 2022

We could keep the order in the rooms. Inside schedule.json, there is an array of rooms, which has some sort.

@jtanguy
Copy link
Author

jtanguy commented Oct 17, 2022

Did we loose the sort when casting into a Set ?

@RobinCaroff
Copy link
Collaborator

Good idea! Yes indeed we could use this order; however I'll need to update the sorting algorithm on the app's side as it groups sessions by start times but the does not sort the sessions by rooms. I fear that the update won't make it to production before the start of the event (review process is currently awfully long...). I'll let you know how it goes!

@RobinCaroff RobinCaroff self-assigned this Oct 17, 2022
RobinCaroff added a commit that referenced this issue Oct 3, 2023
📣 Adds sort index for rooms as suggested in #88.
@RobinCaroff
Copy link
Collaborator

Done for Android in #149

@RobinCaroff RobinCaroff added the ios iOS app label Oct 3, 2023
@RobinCaroff RobinCaroff assigned SRihet and unassigned RobinCaroff Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature ios iOS app shared module Shared module
Projects
None yet
Development

No branches or pull requests

3 participants