Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Remove manager role #12588

Open
2 tasks
mnigh opened this issue Jan 23, 2025 · 0 comments
Open
2 tasks

♻️ Remove manager role #12588

mnigh opened this issue Jan 23, 2025 · 0 comments
Labels
debt Refactor or improve existing code.

Comments

@mnigh
Copy link
Contributor

mnigh commented Jan 23, 2025

♻️ Debt

Remove manager role that was never really implemented and was meant for the manager dashboard.

🙋‍♀️ Proposed Solution

api/database/factories/UserFactory.php

  • Remove asManager function
  • Remove any references to asManager function

api/config/rolepermission.php

  • Remove manager role
  • Remove managerMembership resource
  • Remove any permissions with managerMembership

Screenshot

Image

Deployment

Re-run permission seeder to remove manager resource and permissions: php artisan db:seed --class=RolePermissionSeeder

✅ Acceptance Criteria

  • manager role not part of codebase
  • permission seeder run php artisan db:seed --class=RolePermissionSeeder
@mnigh mnigh added the debt Refactor or improve existing code. label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debt Refactor or improve existing code.
Projects
GC Digital Talent
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnigh