Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› Work experience form - adding a skill resets all the sub fields #12434

Closed
1 task
yonikid15 opened this issue Jan 8, 2025 · 1 comment Β· Fixed by #12435
Closed
1 task

πŸ› Work experience form - adding a skill resets all the sub fields #12434

yonikid15 opened this issue Jan 8, 2025 · 1 comment Β· Fixed by #12435
Assignees
Labels
bug Something isn't working.

Comments

@yonikid15
Copy link
Contributor

πŸ› Bug

Adding a skill to the work experience resets all the sub fields.

πŸ¦‹ Expected Behaviour

Adding a skill to a work experience shouldn't reset sub fields.

πŸ•΅οΈ Details

This useEffect was added to reset fields when switching between categories. This is a practice we've been using to prevent adding unwanted fields to the mutation.

πŸ“‹ Steps to Reproduce

  1. Begin creating a work experience.
  2. Select an employment category, and fill out a couple sub fields.
  3. Scroll down and add a new skill.
  4. Scroll back up and see the fields have been reset.

πŸ“Έ Screenshot

localhost_8000_en_applicant_career-timeline_create

πŸ™‹β€β™€οΈ Proposed Solution

βœ… Acceptance Criteria

  • Adding a new skill doesn't reset work experience fields
@yonikid15 yonikid15 added the bug Something isn't working. label Jan 8, 2025
@yonikid15 yonikid15 self-assigned this Jan 8, 2025
@yonikid15 yonikid15 moved this to πŸ— In progress in GC Digital Talent Jan 8, 2025
@tristan-orourke tristan-orourke moved this from πŸ— In progress to πŸ‘€ In review in GC Digital Talent Jan 9, 2025
@brindasasi
Copy link
Contributor

Steps to re-produce

  1. Create a work experience with Government and another work experience with Armed forces
  2. Fill all the details for all fields
  3. Apply for Published -Complex pool in the local
  4. Attach those 2 experiences to all the essential skills and add some details
  5. Submit the application
  6. Go to admin side and download the application (not the profile)
  7. Observe under Essential you see this missing info
Image

@github-project-automation github-project-automation bot moved this from πŸ‘€ In review to βœ… Done in GC Digital Talent Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
Status: βœ… Done
Development

Successfully merging a pull request may close this issue.

2 participants