Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Bump or remove react-to-print #12387

Open
2 tasks
esizer opened this issue Dec 27, 2024 · 0 comments
Open
2 tasks

♻️ Bump or remove react-to-print #12387

esizer opened this issue Dec 27, 2024 · 0 comments
Labels
debt Refactor or improve existing code. review in refinement Ready to be looked at and pulled into "ready to dev"

Comments

@esizer
Copy link
Member

esizer commented Dec 27, 2024

♻️ Debt/Refactor

New, breaking changes, version of react-to-print

🕵️ Details

There is a new, breaking, version of react-to-print but we only use it to download the skills. I wonder if we actually move this download to the server as an immediate download so we can instead remove a dependency instead of upgrading it.

🙋‍♀️ Proposed Solution

  1. Upgrade react-to-print
  2. Move download to server and remove react-to-print

✅ Acceptance Criteria

  • react-to-print on latest version or;
  • Skills download on server, react-to-print removed
@esizer esizer added the debt Refactor or improve existing code. label Dec 27, 2024
@mnigh mnigh added the review in refinement Ready to be looked at and pulled into "ready to dev" label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Refactor or improve existing code. review in refinement Ready to be looked at and pulled into "ready to dev"
Projects
Status: No status
Development

No branches or pull requests

2 participants