Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Upgrade react-toastify to v11 #12338

Closed
3 tasks
esizer opened this issue Dec 19, 2024 · 0 comments · Fixed by #12426
Closed
3 tasks

♻️ Upgrade react-toastify to v11 #12338

esizer opened this issue Dec 19, 2024 · 0 comments · Fixed by #12426
Assignees
@mnigh
Labels
debt Refactor or improve existing code.

Comments

@esizer
Copy link
Member

esizer commented Dec 19, 2024

♻️ Debt/Refactor

New version of react-toastify has been released with breaking changes.

🙋‍♀️ Proposed Solution

Follow the migration guide.

✅ Acceptance Criteria

  • react-toastify is on v11
  • No visual diff unless approved by a designer
  • Functionality remains the same
@esizer esizer added the debt Refactor or improve existing code. label Dec 19, 2024
@mnigh mnigh self-assigned this Jan 7, 2025
@mnigh mnigh moved this to 🏗 In progress in GC Digital Talent Jan 7, 2025
@mnigh mnigh mentioned this issue Jan 7, 2025
Merged
@mnigh mnigh moved this from 🏗 In progress to 👀 In review in GC Digital Talent Jan 7, 2025
@mnigh mnigh moved this from 👀 In review to 🏗 In progress in GC Digital Talent Jan 7, 2025
@mnigh mnigh moved this from 🏗 In progress to 👀 In review in GC Digital Talent Jan 7, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in GC Digital Talent Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnigh mnigh

Labels
debt Refactor or improve existing code.
Projects
GC Digital Talent
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Debt] Updates Toast component and react-toastify GCTC-NTGC/gc-digital-talent
2 participants
@mnigh @esizer