Fails to read some saves

[2V3EvG4LMJFdRe]

Thank you for this wonderful tool. I have 2 memory cards from 20 years ago (!) filled with savefiles waiting to be rescued, some more recent than others. The process has worked great up to the .mcr conversion for most saves, but some seemingly fail to load. On one memory card (bootleg, newer), it is 1 out of 10 saves while on the other memory card (official, older), it is 6 out of 15 saves. I have tried copying the files from one card to the other with the PSX firmware, but they still fail to read.

I could share the recordings attempts I made for each of these saves, but they really just amount to a really quick message that flashes for a second:

(from BASLUS-00594G023p@C)

Sadly, I don't have copies of the games handy to say whether they work with the PSX still or they have become corrupted somehow indeed.

[G4Vi]

Thanks for the bug report. So the issue is that after it briefly displays "Opening file" it goes back to the list of save filenames? If that is happening, it is failing to open the save file.

I tested a Metal Gear Solid save: BASLUS-00957V@@C@@@A and discovered a string truncation/off by 1 error, preventing saves with 20 character filenames from being loaded. d2c917f

I'll make a new release tonight after cleaning up some of the string handling.

[2V3EvG4LMJFdRe]

Awesome! Yes, it just flashes that message and goes back to the list of filenames. Definitely sounds like a problem opening the file and not the file itself now that you put it that way.

Here are the codes of the files that failed to open, they are all quite lengthy so you're probably right about your guess on the filename:

BASCUS-942440000000
BASLUS-00594G001p@B
BASLUS-00594G023p@C
BASLUS-00594V00000@
BASLUS-00707SILENTO
BISLPS-01591DESTREG
BISLPS-01915-MSHVSS

[G4Vi]

@2V3EvG4LMJFdRe Please try https://github.com/G4Vi/psx_screen_dumper/releases/tag/v0.11.1

Edit: please try https://github.com/G4Vi/psx_screen_dumper/releases/tag/v0.11.2 instead, I made some string optimizations

[2V3EvG4LMJFdRe]

I thought I would be able to test it by now, but I haven't found the time to since I need to ask around for a CD burner, sorry. Hopefully it won't take too long.

[G4Vi]

@2V3EvG4LMJFdRe No rush, thanks for the update.