Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding node inputs / InputSocket arrays #21

Open
Fydar opened this issue Mar 8, 2020 · 0 comments
Open

Expanding node inputs / InputSocket arrays #21

Fydar opened this issue Mar 8, 2020 · 0 comments
Assignees
Labels
📦 RPGCore.Behaviour Issue related to the RPGCore.Behaviour package New feature or request

Comments

@Fydar
Copy link
Owner

Fydar commented Mar 8, 2020

Support nodes having arrays of InputSockets so that they may accept an arbitrary amount of inputs. This is useful for nodes like the AddNode that would happily add an arbitrary amount of values together.

I have some basic editor support for this feature that allows InputSockets to be used in an array, however, the socket mapping API isn't sufficient for this and will need a rework.

image

The current socket mapping API only allocates an array of the exact sized required to connect all of the inputs. That will need to be changed as the number of inputs is not a fixed value anymore. Other API alternatives could include yield return for every input or returning struct-wrapped arrays that get concatenated together. Returning struct-wrapped is likely to make the smallest amount of allocations.

Whatever way I go about implementing this, there will be a slight performance regression.

@Fydar Fydar added New feature or request 📦 RPGCore.Behaviour Issue related to the RPGCore.Behaviour package labels Mar 8, 2020
@Fydar Fydar self-assigned this Mar 8, 2020
Fydar added a commit that referenced this issue Mar 8, 2020
🚧 Deserialize arrays of InputSockets properly
🐛 Misc. fixes to the BehaviourManifest
@Fydar Fydar moved this to Todo in RPGCore Development Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 RPGCore.Behaviour Issue related to the RPGCore.Behaviour package New feature or request
Projects
Development

No branches or pull requests

1 participant