Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: remove lightningKillsDropsFix rule #169

Open
peow opened this issue Mar 31, 2024 · 2 comments
Open

suggestion: remove lightningKillsDropsFix rule #169

peow opened this issue Mar 31, 2024 · 2 comments

Comments

@peow
Copy link

peow commented Mar 31, 2024

the main mod (Carpet) already has this functionality

image
https://github.com/gnembon/fabric-carpet/wiki/Current-Available-Settings#lightningkillsdropsfix


image
https://github.com/fxmorin/carpet-fixes/wiki/Available-Settings#lightningkillsdropsfix

so they overlap
[13:24:30] [main/WARN]: Method overwrite conflict for method_5800 in carpet-fixes.mixins.json:itemFixes.ItemEntity_lightningKillsDropsMixin from mod carpet-fixes, previously written by carpet.mixins.ItemEntityMixin. Skipping method.

@FxMorin
Copy link
Owner

FxMorin commented Apr 26, 2024

I wrote the original rule and asked gnembon to remove it, and he never did

@peow
Copy link
Author

peow commented Apr 26, 2024

i see, im sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants