Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type union coercion fails when record types come before others #258

Open
dacreify opened this issue Jun 15, 2020 · 0 comments
Open

Type union coercion fails when record types come before others #258

dacreify opened this issue Jun 15, 2020 · 0 comments

Comments

@dacreify
Copy link

Summary

The match-clj? implementation on RecordType doesn't check if clj-map is actually a map, which it may not be if part of a type union.

Repro

  1. Go into jackdaw.serdes.avro-test/schema-type-test to the (testing "union" form
  2. In the avro-schema binding move record-1-schema so that it's the first element of the vector
  3. Run the test and observe that it fails
dacreify added a commit to dacreify/jackdaw that referenced this issue Jun 15, 2020
@dacreify
fix for FundingCircle#258
33ac94d
darin-reify added a commit to reifyhealth/jackdaw that referenced this issue Aug 23, 2022
@darin-reify
[FundingCircle#258] fix type union coercion error when record types c…
c297ff3 
…ome before others
darin-reify added a commit to reifyhealth/jackdaw that referenced this issue Aug 23, 2022
@darin-reify
Merge pull request #3 from reifyhealth/258-union-coercion-fix
62807ab 
[FundingCircle#258] fix type union coercion error when record types come before ot…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dacreify