Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sign the transfer transaction on mobile #26

Open
mpoplavkov opened this issue Dec 14, 2023 · 0 comments
Open

Do not sign the transfer transaction on mobile #26

mpoplavkov opened this issue Dec 14, 2023 · 0 comments

Comments

@mpoplavkov
Copy link
Contributor

The current implementation of the build transfer transaction method signs the transaction:

wallet.add_witnessses(&mut tx_builder);

Without that, the call of tx_builder.build would fail, because it requires signatures to be present.

This makes it insecure to send such signed transaction requests over network without the desire to execute them (eg for simulation)

See the issue on forum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant