Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite leaderboard to remove react-table-6 #365

Open
UncleClapton opened this issue Jul 26, 2021 · 0 comments
Open

Rewrite leaderboard to remove react-table-6 #365

UncleClapton opened this issue Jul 26, 2021 · 0 comments
Assignees
Labels
Meta | Needs more Info ❓ An issue or PR that requires more info from the submitter. Type | Task ⚙️ An issue or PR that describes or performs a maintenance task or chore.

Comments

@UncleClapton
Copy link
Member

react-table-6 will soon become a React 18 upgrade blocker due to it's use of UNSAFE_ methods.

We need to investigate paths forward.

  • Upgrade to react-table v7
    • Is an option, but it is drastically different and would require a rewrite from scratch anyway.
    • Further, v7 tends to lead to some somewhat ugly code that I would rather want to avoid, and we need to bring our own UI. from scratch
  • Finding another table component
    • Not sure if we want to lock ourselves into another component like this again?
  • Rewrite from scratch with a custom brewed component for listing
    • Would give us reason to abstract some pagination logic from blogs for other purposes.
    • Full stylistic control would be a bonus
@UncleClapton UncleClapton added the Type | Task ⚙️ An issue or PR that describes or performs a maintenance task or chore. label Jul 26, 2021
@EladKarni EladKarni self-assigned this Sep 16, 2021
@UncleClapton UncleClapton added the Meta | Needs more Info ❓ An issue or PR that requires more info from the submitter. label Sep 16, 2021
@UncleClapton UncleClapton added this to the 2.15.0 milestone Oct 22, 2021
@UncleClapton UncleClapton removed this from the 2.15.0 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta | Needs more Info ❓ An issue or PR that requires more info from the submitter. Type | Task ⚙️ An issue or PR that describes or performs a maintenance task or chore.
Projects
None yet
Development

No branches or pull requests

2 participants