Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Fileinfo PHP extension a requirement or add warning when missing #313

Open
clarkwinkelmann opened this issue Feb 21, 2022 · 0 comments

Comments

@clarkwinkelmann
Copy link
Member

We use mime_content_type as fallback to get the MIME type, but we don't require fileinfo PHP extension.

We have a try/catch around mime_content_type so I think this makes the extension optional, but I haven't actually tested what happens when the extension is disabled.

The suggestion is either:

  • Make Fileinfo extension required
  • Add warning to extension settings page if extension is disabled

FoF Upload should work fine without fileinfo if you use common MIME types. But if you want to use more advanced types including those that might be custom to the specific server, the fallback is useful or even required if you don't want all unknown files to default to the same value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant