kernel.environmentconfig: mistmatch between documentation and implementation

[tucksaun]

The current documentation states:

It allows you to force using a given environment. If it is not set, it uses APP_ENV environment variable if defined or falls back to test.

However, the current code does not implement this:

SymfonyExtension/src/ServiceContainer/SymfonyExtension.php

Lines 185 to 191 in dfb1c9c

	private function setupTestEnvironment(string $fallback): void
	{
	// If there's no defined server / environment variable with an environment, default to configured fallback
	if (($_SERVER['APP_ENV'] ?? $_ENV['APP_ENV'] ?? null) === null) {
	putenv('APP_ENV=' . $_SERVER['APP_ENV'] = $_ENV['APP_ENV'] = $fallback);
	}
	}

The actual behavior of the code is to setup only if APP_ENV is not already defined (so not to force it) and the configuration value fallbacks to test (see

SymfonyExtension/src/ServiceContainer/SymfonyExtension.php

Line 74 in dfb1c9c

$this->setupTestEnvironment($config['kernel']['environment'] ?? 'test');

).

I'm willing to submit a PR to fix this issue but wanted to know which way the maintainers want to move: fix the documentation that is misleading or fix the behavior in order to match the documentation?

[walva]

Hello @tucksaun,

I feel a bit guilty… I wrote this part of the documentation.

I lost a couple of hours because I wasn't aware of this option, so I wanted to inform. I cannot say which option is the best, but willing to help if I can.

[tucksaun]

Hey @walva 👋

Please don't: TBH intuitively a colleague and I though this would be the behaviour 🙂
Thank you for the help proposition, will keep in mind. But we need some guidance to know which way to go.
As you are a contributor, do you know someone we can ping maybe?

[walva]

I’m sorry this was my only contribution even if I’m a big user of this extension. I would definitely one of the top contributors like @pamil or @Yozhef.