Footer buttons overlap content on privacy page.

[edwh]

Viewport size is 1600 × 769.

[cppmonkey]

Same applied to Terms and Disclaimer

And contact contains inconsist. (Included footer twice? Not inspected HTML)

[edwh]

Thanks, if I get to this issue I'll look at those too. Feel free to fix them :-).

…

------ Original Message ------ From: "KodApa85" <[email protected]> To: "Freegle/iznik-client" <[email protected]> Cc: "Edward Hibbert" <[email protected]>; "Author" <[email protected]> Sent: 11/08/2018 16:08:54 Subject: Re: [Freegle/iznik-client] Footer buttons overlap content on privacy page. (#9)

<https://user-images.githubusercontent.com/637139/43993067-07a1ad24-9d80-11e8-9720-a7ef96cf1aec.png> Same applied to Terms and Disclaimer And contact contains inconsist. (Included footer twice? Not inspected HTML) <https://user-images.githubusercontent.com/637139/43993105-89ff5dac-9d80-11e8-8146-10903d10b784.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADdeC1cZvNKTknQAac9hCGk5zxVNiWmks5uPvOGgaJpZM4SvKMu>.

[cppmonkey]

If I get chance.
I'd say you'll be a little more familiar with the code/structure than me, but then again that hasn't stopped me tackling other projects before.
Oxidized is written in Ruby, and I'd never written anything in that until a few months ago

[codepotato]

@edwh @cppmonkey Did this issue ever get resolved? If not, I'll happily take a look.

[edwh]

@codepotato I believe this is still an issue, on at least some viewport sizes.

[Lurux]

I there, I found a simple fix that would work for all the pages but I can't find the main CSS sheet to add this rule (all I see in my inspector are inline stylesheets, but I guess they must come from somewhere ?)

Add this to fix all the pages:
.pageContent { padding-bottom: 100px }

Edit: Found it ! Forking now...

[edwh]

I'm not sure that fix would work for infinite scroll pages like My Groups, would it? Those go to the bottom of the page.

…

On 7 July 2019 13:08:35 BST, Lurux ***@***.***> wrote: I there, I found a simple fix that would work for all the pages but I can't find the main CSS sheet to add this rule (all I see in my inspector are inline stylesheets, but I guess they must come from somewhere ?) **Add this to fix all the pages:** .pageContent { padding-bottom: 80px; } **If you tell me where the sheet is I will do it for you.** I don't plan on changing all the pages if this really inline style tough. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #9 (comment)

[Lurux]

I'm not sure that fix would work for infinite scroll pages like My Groups, would it? Those go to the bottom of the page.

What do you mean ?

There will be a small blank space at the bottom of the pages where the footer is actually on the left corner, but I don't think that's really a big deal.

Apart from that, I tried in the browser and everything works fine.

[edwh]

pageContent is a class that's added to lots of pages, not just the privacy page. Some of those pages run right to the bottom of the page, so you'll get a blank. Here's an example screenshot:

…

------ Original Message ------ From: "Lurux" <[email protected]> To: "Freegle/iznik-client" <[email protected]> Cc: "Edward Hibbert" <[email protected]>; "Mention" <[email protected]> Sent: 07/07/2019 14:48:48 Subject: Re: [Freegle/iznik-client] Footer buttons overlap content on privacy page. (#9)

>I'm not sure that fix would work for infinite scroll pages like My >Groups, would it? Those go to the bottom of the page. > What do you mean ? There will be a small blank space at the bottom of the pages where the footer is actually on the bottom-left corner, but I don't think that's really a big deal. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9?email_source=notifications&email_token=AAAN26FQ777CMK3SKPGPAZ3P6HX4BA5CNFSM4EV4UMXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLL4KA#issuecomment-509001256>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAN26GQY5M5AGXXZMFFU5TP6HX4BANCNFSM4EV4UMXA>.

[Lurux]

I know, that's what I said. Please refer to my answer above.

[edwh]

I don't want to have a margin at the bottom of all pages. The ones with infinite scrolling are examples - infinite scroll typically goes down to the bottom of the window.

…

On 17 July 2019 19:39:27 BST, Lurux ***@***.***> wrote: I know, that's what I said. Please refer to my answer above. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #9 (comment)

[Lurux]

Ok, I'll find another solution, then :)

[edwh]

Thanks :-).

…

------ Original Message ------ From: "Lurux" <[email protected]> To: "Freegle/iznik-client" <[email protected]> Cc: "Edward Hibbert" <[email protected]>; "Mention" <[email protected]> Sent: 18/07/2019 12:39:15 Subject: Re: [Freegle/iznik-client] Footer buttons overlap content on privacy page. (#9)

Ok, I'll find another solution, then :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#9?email_source=notifications&email_token=AAAN26DBGXG6ECFLRP5I773QABI6HA5CNFSM4EV4UMXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2IGRCI#issuecomment-512780425>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAN26GJZ2VHSFNMQ37ZWM3QABI6HANCNFSM4EV4UMXA>.