Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same person validating more than once causes more than one validation #460

Open
bhaugen opened this issue Jul 8, 2018 · 1 comment
Open
Labels

Comments

@bhaugen
Copy link

bhaugen commented Jul 8, 2018

From telegram:

Michalis K
Just bumped onto this bug...
Same person Validated 3 (!) times and the commitment appear as validated in Agents (and in Kispagi too)
https://agent.fair.coop/canvas/402/validate
Seems that sometimes (maybe when you click too fast? maybe a delay of some kind would help?) it is possible to validate more than once at the same time (it has happened to me several times)

Maybe can fix in the validation-saving code. If the same person has validated this event before, don't create another validation?

@bhaugen bhaugen added the bug label Jul 8, 2018
@fosterlynn
Copy link
Collaborator

This was probably happening a few days ago when the UI was not working properly, and people couldn't see when they had already validated.

We could add that check in the validation saving code, and that would be correct to have it on the server also, but I doubt it is worth it for a feature such as validation, since I am pretty sure the UI now covers it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants