Fix incompatibility with upcoming YouTube.js version #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 25, 2024
ChunkyProgrammer
approved these changes
Nov 25, 2024
PikachuEXE
approved these changes
Nov 25, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 29, 2024
* development: (41 commits) Translated using Weblate (Afrikaans) Translated using Weblate (Portuguese) Translated using Weblate (Welsh) Translated using Weblate (Spanish) Translated using Weblate (Polish) Translated using Weblate (Urdu) Translated using Weblate (Chinese (Traditional Han script)) Switch the data import to the Web File System API (FreeTubeApp#6222) Translated using Weblate (Serbian) Translated using Weblate (Basque) Translated using Weblate (Basque) Translated using Weblate (Icelandic) Translated using Weblate (Basque) Translated using Weblate (French) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified Han script)) Bump electron from 32.2.5 to 33.2.0 (FreeTubeApp#6231) Fix incompatibility with upcoming YouTube.js version (FreeTubeApp#6233) Translated using Weblate (Estonian) Translated using Weblate (Portuguese (Brazil)) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incompatibility with upcoming YouTube.js version
Pull Request Type
Related issue
LuanRT/YouTube.js#812
Description
The upcoming YouTube.js 12.0.0 update removes the
*Endpointconstants and functions that we were using to build the payloads for the subscriptions page API calls. This pull request switches to just passing the information to theactions.execute()method directly (so doing what the builder function used to do ourselves), which makes FreeTube compatible with YouTube.js 12.0.0 and the change is also compatible with the current version of YouTube.js that we are using.Testing
Desktop