Added buttons to hide hidden channels/text

[JL0000]

Added buttons to hide hidden channels/text

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #5652

Description

• Added toggle switches to hide/show the channels and text hidden by filters set by user
• Grouped the toggles together with the filtering into a new section

Screenshots

Before

After

Testing

Settings persist after closing the application.

Desktop

• OS: MacOs
• OS Version: 15.1
• FreeTube version: v0.22.0 Beta

Additional context

[efb4f5ff-1298-471a-8973-3d47447115dc]

Errors when entering the settings page and using the toggles

VirtualBoxVM_civ1heeKvZ.mp4

[JL0000]

Fixed it.

[PikachuEXE]

I think the label reads a bit confusing to me
Show Hidden Channels at first I thought it was disabling hiding channels then I read Show Hidden Text.
I think it would be better to label them as something like "show all already entered list of channels/text" (Not sure what exact words to use)
Or move the controls below each text input field (though not the best position I guess) so users can relate that control to the list of videos/texts

[JL0000]

What do you think about List Hidden Channels and List Hidden Words?

[PikachuEXE]

Show Stored/Saved Hidden Channels & Show Stored/Saved Hidden Keywords?
Weird to see List...

[JL0000]

Because I name this section Content Filter I think Show Channels Added to Content Filter and Show Keywords Added to Content Filter works well. If content filter is vague, then Show Stored Hidden Channels and Show Stored Hidden Keywords works well too.

[PikachuEXE]

Show Added Channels + Show Added Keywords?
Assuming they are under heading Content Filter

[kommunarr]

suggestion: I hate to be the guy who comes in late with new things to say. This feature does work well, but I am still skeptical of the toggle setup. Couldn't we do a Show / Hide button where the content is supposed to appear / disappear (e.g., like our recent Hide/Show description feature) instead of toggles above the whole container? That way the positional and logical relationship of the control to the corresponding section is much more clear. I ask particularly because I thought I was in the wrong branch for a couple minutes when trying to test this.

[JL0000]

suggestion: I hate to be the guy who comes in late with new things to say. This feature does work well, but I am still skeptical of the toggle setup. Couldn't we do a Show / Hide button where the content is supposed to appear / disappear (e.g., like our recent Hide/Show description feature) instead of toggles above the whole container? That way the positional and logical relationship of the control to the corresponding section is much more clear. I ask particularly because I thought I was in the wrong branch for a couple minutes when trying to test this.

I think it does make it more coherent. Maybe to the right of each tooltip?
Also, can you link me the PR for the "recent Hide/Show description feature" please?

[kommunarr]

Ah, I didn't see that wasn't merged yet. Here's that implementation I'm thinking of for reference!

[efb4f5ff-1298-471a-8973-3d47447115dc]

I would like the showTags to be true by default so that this doesnt visually change anything for our users in the next version. If someone decided to uncheck it than that should be remembered within the session but also on next startup. This is how it works with all the toggles in the settings

Settings dont get remembered when navigating away and back to the settings page

VirtualBoxVM_An3To9T6Qf.mp4