Local API: Add support for home tab on channels

[ChunkyProgrammer]

Local API: Add support for home tab on channels

Pull Request Type

• Feature Implementation

Description

This PR adds support for parsing the home page on channels

Screenshots

Testing

(Make sure to use Local API as primary API!)

• go to a variety of different channels (ex: Linus Tech Tips, Music, - Topic channels)

• make sure home page properly displays

• try disabling channel homepage in distraction free settings

• make sure that homepage is no longer visible

Desktop

• OS: Linux Mint
• OS Version: 22
• FreeTube version: 0.22.0

[absidue]

How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works.

[ChunkyProgrammer]

How should we handle related/featured channels and game cards? Before this pull request they were shown on the about tab but now they are duplicated to the home page too. If we move them to the home page we need to make sure that the "Hide Feature Channels" setting still works.

Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it).

I'll look into getting the hide featured channels to work with the homepage as well

[ChunkyProgrammer]

Good point, I think it's okay for the information to be duplicated on the home page as long as the code isn't duplicated (ex: we should set the featuredchannels as part of the home page parsing instead of having a separate method for parsing it).

I'll look into getting the hide featured channels to work with the homepage as well

Done: 43aeeef

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Is it possible to hide shorts when the distraction free setting is enabled?

[ChunkyProgrammer]

Is it possible to hide shorts when the distraction free setting is enabled?

I think it'd be possible to hide some of the shorts on the home page but not all of them (I'll have to double check).

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[PikachuEXE]

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

I interpretation is that Hide Channel Shorts is for hiding any displayed shorts in single channel view & channel short tab is the only place before home tab is introduced

[efb4f5ff-1298-471a-8973-3d47447115dc]

Also, would we want to hide shorts on the home page? I thought the hide shorts setting was just for hiding the shorts tab?

I interpretation is that Hide Channel Shorts is for hiding any displayed shorts in single channel view & channel short tab is the only place before home tab is introduced

Yeah maybe its best to just leave this as is

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[efb4f5ff-1298-471a-8973-3d47447115dc]

PR LGTM, BUT

Going to play devils advocate here: Why only expand one category in the home tab and not all? Users have now to click on every category to be expanded to see the content.

Knowing our users a bit thats a thing they dont like, making extra clicks

[absidue]

When visiting an artist topic channel such as https://www.youtube.com/channel/UCRw0x9_EfawqmgDI2IgQLLg I noticed that the home page is empty and the console contains warnings about an unknown lockup view type ALBUM. The data structure for that type seems to be the same as for playlists and podcasts, as it should just be a one line change to add that type to the switch-case, could you please do it as part of this pull requests? Everything else LGTM! :)

[ChunkyProgrammer]

as it should just be a one line change to add that type to the switch-case, could you please do it as part of this pull requests? Everything else LGTM! :)

Updated

[PikachuEXE]

For special channel like https://www.youtube.com/channel/UCStaiwu-FAgp_RC_tBiLh9A I see video tab selected (even though home tab can be used)
Any reason?

[ChunkyProgrammer]

For special channel like https://www.youtube.com/channel/UCStaiwu-FAgp_RC_tBiLh9A I see video tab selected (even though home tab can be used) Any reason?

Should be fixed now