Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Native Picture-in-picture on macOS #6234

Closed
3 tasks done
poweruser82 opened this issue Nov 26, 2024 · 3 comments
Closed
3 tasks done

[Feature Request]: Native Picture-in-picture on macOS #6234

poweruser82 opened this issue Nov 26, 2024 · 3 comments

Comments

@poweruser82
Copy link

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Current implementation of Picture in Picture on the macOS app is useful only when you are inside the app.
You can't continue to watch the video while having other windows open or switching spaces.

Proposed Solution

Use macOS native PiP mode

Alternatives Considered

Issue Labels

improvement to existing feature

Additional Information

No response

@absidue
Copy link
Member

absidue commented Nov 26, 2024

Could you please provide screen-recording of what you mean by "You can't continue to watch the video while having other windows open"?

@poweruser82
Copy link
Author

I'm sorry, I was wrong about that. The player stays on top in a normal space and even when switching to other normal spaces.
However it isn't visible in full screen apps or in spaces with split screen apps.

@absidue
Copy link
Member

absidue commented Nov 26, 2024

Okay that's good to know.

FreeTube uses Electron which is built on top of Chromium. Chromium uses a custom picture-in-picture implementation so that it works the same on Windows, macOS and Linux.

We do not have control over things that low level, it also seems very unlikely that Chromium would start using the native macOS picture-in-picture APIs any time soon as it would require a lot of changes not just to the picture-in-picture handling but also major changes to their video handling pipeline. The amount of time and effort that would be required to make those changes and then fixing all the problems that appear when you make changes that major, are probably not worth it for them, considering that you can easily work around it by not fullscreening another window.

@absidue absidue closed this as completed Nov 26, 2024
@absidue absidue reopened this Nov 26, 2024
@absidue absidue closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To assign
Development

No branches or pull requests

2 participants