Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Download URL in sbom.spdx is not exactly the same than the tag URL #1200

Open
finger42 opened this issue Nov 29, 2024 · 2 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@finger42
Copy link

Describe the issue
In the generated SBOM file:
https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/V11.1.0/sbom.spdx#L15

is the URL: https://github.com/FreeRTOS/FreeRTOS-Kernel/tree/v11.1.0
which leads to 404.
Reason is that the 'v' should be written upper case 'V'

I dont know why the URL is case sensitive?

So the URL:
https://github.com/FreeRTOS/FreeRTOS-Kernel/tree/V11.1.0
is working.

From my search the sbom.spdx file is generated by:
https://github.com/FreeRTOS/CI-CD-Github-Actions/blob/main/sbom-generator/scan_dir.py#L35
Where the manifest file gets parsed and generates the URL.

The manifest file:
https://github.com/FreeRTOS/FreeRTOS-Kernel/blob/V11.1.0/manifest.yml
contains the URL with lower 'v'

So the Tag URL and the manifest file version differs.

@finger42 finger42 added the documentation Improvements or additions to documentation label Nov 29, 2024
@kstribrnAmzn
Copy link
Member

What a silly thing to get wrong - thank you for catching this! It looks like the URL is case sensitive as it needs to match the tag exactly. Our release tags use a capitalized V.

For now, I'll raise a PR to update the main branch to use the capitalized V. I'll also start a discussion with the team to see if we want to release a patch version of FreeRTOS 11.1 to correct this URL.

@kstribrnAmzn
Copy link
Member

Fix - #1201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants