New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #1

Open

FredrIQ opened this issue May 15, 2014 · 0 comments

Owner

FredrIQ commented May 15, 2014

Currently, code is split up in the following scripts:

fiqbot.mrc for the fiq-bot part
fiqbot-config.mrc for configuration
tyrant-resources.mrc for xml pulling and card helper functions
tyrant-tasks.mrc for everything else related to tyrant communication

This makes files a bit bloated (especially fiqbot and tyrant-tasks). It would be good if the following was done:

Rewrite the socket logic for Tyrant to pull all the data first, then process it - this is to avoid strange errors resulting of a connection loss mid-retrieval.
Split all the "tasks" into seperate files for each thing, making code overview easier
Split FIQ-bot commands into seperate files as well. Perhaps implement some kind of autoload logic in fiqbot.mrc to allow this rather seamlessy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment