Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test WDL for struct and map datatype inputs #27

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

tefirman
Copy link
Collaborator

Description

  • Adding a WDL that demonstrates the usage of struct datatypes.
  • Uses a custom struct to organize metadata, showing how to define and work with structured data types in WDL.

Related Issues

Testing

  • Ran both locally using miniwdl, finished successfully.

@sitapriyamoorthi
Copy link
Collaborator

@tefirman This looks great! I am wondering if you would want to add these as well:

  1. Testing optional fields in Structs
  2. Testing nested structs
  3. Testing default values in structs

@sitapriyamoorthi
Copy link
Collaborator

@tefirman for the map tests I was wondering if it might be helpful to test these cases as well:

  1. Handling empty map
  2. Nested maps
  3. Testing duplicate keys
  4. Testing if maps are returned as outputs

@sitapriyamoorthi
Copy link
Collaborator

@tefirman also I think we should try and specify a specific docker container to avoid and issues with version changes. Eventhough i understand that these commands we are using are v.basic but just to be safe!

@seankross seankross added the unit test Adding or modifying a unit test label Dec 18, 2024
@tefirman
Copy link
Collaborator Author

Thanks @sitapriyamoorthi ! I put a few more tasks into both workflows to address your suggestions above. Great call on adding the specific Docker image versions, updated that as well. Mind taking another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Adding or modifying a unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map & Structs functionality
3 participants