Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource allocation (CPU/memory/ retries/time) #15

Open
sitapriyamoorthi opened this issue Dec 16, 2024 · 2 comments
Open

Resource allocation (CPU/memory/ retries/time) #15

sitapriyamoorthi opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
unit test Adding or modifying a unit test

Comments

@sitapriyamoorthi
Copy link
Collaborator

sitapriyamoorthi commented Dec 16, 2024

If CPU,retries, time and memory allocations are correctly handled

@tefirman
Copy link
Collaborator

@sitapriyamoorthi -- I believe this functionality is demonstrated in "helloDockerHostname.wdl", do you agree?

@sitapriyamoorthi
Copy link
Collaborator Author

sitapriyamoorthi commented Dec 17, 2024

@tefirman yes i think the "helloDockerHostname.wdl" does test the ability to spin up a docker and use of the specified memory allocations.

I guess what is missing in this test (or could be added into the WDL) would be testing these use cases:

  1. Testing dynamic run time variables ( a user provides dynamic values as inputs) and making sure that these are actually allocated?

  2. Checking if custom runtime variables are actually used ?

  3. Invalid runtime variables returning a valid meaningful error (but a successful WDL run)

  4. Also probably need to test and validate successful docker pull from different sources?

  • Testing different versions (latest versus x.x.x)
  • Testing fall back mechanism if primary docker source fails?
  • Testing public versus private resources
  1. Also would think about testing JSON files providing custom variables and making sure those are getting utilized as well?

Totally might be an overkill but would be a potentially good way to monitor resource allocations are appropriately being given on the cluster.

I know we also need to test the GPU allocations but I know that there is an issue with testing those with GitHub actions and we potentially needs to create a test and independently check this?

I am going to rename this issue to test in-line (inside the WDL) testing and convert the otherone to test from JSON files that way we have two independent lines of testing. Let me know if that makes sense?

@sitapriyamoorthi sitapriyamoorthi changed the title Testing Custom Runtime Requirements Testing Custom Runtime Requirements (in WDL) Dec 17, 2024
@seankross seankross added the unit test Adding or modifying a unit test label Dec 18, 2024
@sitapriyamoorthi sitapriyamoorthi changed the title Testing Custom Runtime Requirements (in WDL) Resource allocation (CPU/memory/ retries/time) Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Adding or modifying a unit test
Projects
None yet
Development

No branches or pull requests

3 participants