Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validate tab #142

Open
sckott opened this issue Sep 20, 2024 · 3 comments
Open

Improve validate tab #142

sckott opened this issue Sep 20, 2024 · 3 comments
Labels
investigating Still assessing priority, ignore for now

Comments

@sckott
Copy link
Collaborator

sckott commented Sep 20, 2024

Right now we print R list to the output. Do something better than that, maybe:

  • Parse the R list and just print the error messages as html elements rather than an R list?
  • Use sprocket to validate and use that output - not sure if it would be feasible to reuse the CLI output for a browser
@tefirman
Copy link
Collaborator

Just tried out Sprocket's check and lint functionalities; not gonna lie, pretty slick and a much nicer display... Just not sure how difficult it would be to incorporate into the codebase. Which repo actually performs this functionality with WOMtools? Is that proof-api?

@sckott
Copy link
Collaborator Author

sckott commented Oct 10, 2024

it comes from the Cromwell API, not proof-api.

@tefirman tefirman added the investigating Still assessing priority, ignore for now label Oct 10, 2024
@sckott
Copy link
Collaborator Author

sckott commented Oct 10, 2024

yeah investigating is a good label. need to poke around and see what the options are first, then can come back here and get feedback on what to go with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigating Still assessing priority, ignore for now
Projects
None yet
Development

No branches or pull requests

2 participants