Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5: enhanced block editing and self-hosting #224

Open
wants to merge 322 commits into
base: master
Choose a base branch
from

Conversation

mlwilkerson
Copy link
Member

@mlwilkerson mlwilkerson commented Aug 2, 2024

closes #220
closes #212

Original PR: #223 (renamed branch)

TODO:

  • investigate styling behavior in the block editor with WordPress 6.6
  • remove SRI hashes on svg-with-js.css
  • ensure svg styles are always fetched for self-hosting when needed

* wire-up faApiUrl to front end for icon chooser

- also, auto-formatting

* refactor queryCache

* refactor building prefixed keys

* implement clearQueryCache()

* run clearQueryCache() when fetching kits data

* remove console log

* make access token refresh more robust

* refactor access token getter code

* ignore .zed project settings

* add comments

* remove unused

* update phpactor exclusions

* auto-formatting

* sniff fixes

* update phpactor config

* add return type

* adding some more return types

* update doc

* throw NoAccessTokenException

* indicate internal-onlyuse

* remove obsolete code

* improve classic editor TinyMCE plugin, toward 1:1 relationship between icon chooser and TinyMCE instance

* remove obsolete injection of icon chooser container div for classic editor

* update plugin-nu description and version

* disable phpactor phpcs

* distinguish between TinyMCE editors by editor_id

* increase height of property section on style modal to better fit custom color picker

...and auto-formatting

* initial re-write of self-hosting exception messages.

* include missing algo name in exception message

* auto-formatting and cleaning

* update all JS bundles to use lodash-es deep imports to avoid overwriting global lodash

* rebuild block-editor bundle

* rebuild classic-editor bundle

* rebuild icon-chooser bundle

* rebuild admin bundle

* auto-formatting

* update more admin bundle lodash exports to use lodash-es

* rebuild admin bundle

* change the timing of when to load block assets

solves the problem with the global lodash _ being reset to undefined

* rearrange

* auto-formatting

* manual formatting of doc comments

* add block_init.php to phpcs config

* add back a missing lodash has import

* rebuild admin bundle

* in admin bundle, migrate to using the lodash that ships with WordPress

* update block-editor to use the WordPress built-in lodash

* rebuild admin bundle

* use WP built-in lodash for icon-chooser bundle

* use WP built-in lodash for classic-editor bundle

* make the retrieval of an access token conditional on using a kit

* rebuild icon-chooser bundle

* remove custom fixups for globals like lodash and moment

now that we're using @wordpress/scripts more conventionally, we can rely
on those to externalize such libraries and ensure that our bundles don't
load conflicting globals

* WIP: fixing up phpcs errors and warnings

* rename block init file to satisfy phpcs
fix zip bundle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP deprecation for md5() Icons as blocks
2 participants