Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"props.groupComponent is undefined" error #3013

Closed
2 tasks done
dlabrecq opened this issue Dec 18, 2024 · 0 comments · Fixed by #3014
Closed
2 tasks done

"props.groupComponent is undefined" error #3013

dlabrecq opened this issue Dec 18, 2024 · 0 comments · Fixed by #3014
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior

Comments

@dlabrecq
Copy link
Contributor

dlabrecq commented Dec 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct

Victory version

37.3.4

Bug report

The changes related to #2970 causes a "props.groupComponent is undefined" error in our VictoryBar wrapper.

In order for a wrapper to work properly, some static props need to be hoisted (e.g., `role`). Our workaround is to not hoist `getBaseProps`, but would still like to fix `victory-bar/src/victory-bar.tsx` and `victory-bar/src/helper-methods.ts`.

Expected behavior

Use a "?" character when testing `props.groupComponent?.type`, so an error isn't thrown in `victory-bar/src/victory-bar.tsx` and `victory-bar/src/helper-methods.ts`.

Actual behavior

Screenshot 2024-12-18 at 8 57 05 AM

Environment

- Device: Desktop
- OS: Darwin
- Node: v22.11.0
- npm: 10.9.0
@dlabrecq dlabrecq added the Type: Bug 🐛 Oh no! A bug or unintentional behavior label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Oh no! A bug or unintentional behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant