Skip to content
This repository has been archived by the owner on Feb 17, 2022. It is now read-only.

logging errors in the console instead of the dom #81

Closed
wants to merge 1 commit into from

Conversation

mziemer21
Copy link

This might close #13.

Instead of rendering errors to the dom it will log them to the console. This gives much better formatting, and now proptype warnings and error messages are in the same place.
Now:
screen shot 2016-11-11 at 4 45 09 pm
screen shot 2016-11-11 at 4 44 01 pm

Before:
screen shot 2016-11-11 at 4 44 48 pm

@kylecesmat
Copy link
Contributor

The reason we are showing errors in the DOM is so users interacting with the playground don't have to have the devTools open, and it allows people modifying the editor input to see errors quickly.

There might be incentive to show errors in the console (for stacktraces like mentioned in #13 ) but this approach is too limiting. Feel free to submit another PR that preserves the current behavior.

@kylecesmat kylecesmat closed this May 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messages
2 participants