You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
I could imagine consumers of this library wanting to ignore fixed periods when getting the string for a day period in certain locales. Although I wouldn't necessarily advise this usage, someone might prefix the English language day period with the word "Good" as a greeting to users ("Good morning", "Good afternoon", etc.). Without filtering on fixed periods, this would lead to awkward constructions like "Good noon" and "Good midnight".
Implementation-wise, this would involve the following:
Adding a new property to DayPeriodFormatter (naming is probably the hardest part of this feature)
Updating DayPeriodRuleSet.period(for:) to take a second parameter to pass the aforementioned property value to conditionally ignore any fixed period for a given hour.
The text was updated successfully, but these errors were encountered:
I could imagine consumers of this library wanting to ignore fixed periods when getting the string for a day period in certain locales. Although I wouldn't necessarily advise this usage, someone might prefix the English language day period with the word "Good" as a greeting to users ("Good morning", "Good afternoon", etc.). Without filtering on fixed periods, this would lead to awkward constructions like "Good noon" and "Good midnight".
Implementation-wise, this would involve the following:
DayPeriodFormatter
(naming is probably the hardest part of this feature)DayPeriodRuleSet.period(for:)
to take a second parameter to pass the aforementioned property value to conditionally ignore any fixed period for a given hour.The text was updated successfully, but these errors were encountered: