Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom /icons folder bug #72

Open
Myrathi opened this issue Jul 24, 2012 · 0 comments
Open

Custom /icons folder bug #72

Myrathi opened this issue Jul 24, 2012 · 0 comments

Comments

@Myrathi
Copy link

Myrathi commented Jul 24, 2012

There's a quirk where MultiMC won't accept any custom icon files as valid unless there's a default icon override in the folder, already, and the override is the first one to be loaded.

As it stands, the best default icon to override (due to sort order) is: brick

The tests in this ticket assume you've already created the /icons subfolder inside your MultiMC folder.

Broken example 1
  • Your /icons folder is empty.
  • Add an image that is not an override of an existing icon: e.g. test.png
  • Run MultiMC
    Error!
Broken example 2:
  • Add a default icon override to your /icons folder: e.g. brick.png
  • Add an image that does not override -and- sorts before the default filename: e.g. aardvark.jpg
  • Run MultiMC
    Error!
Working example:
  • Add a default icon override to your /icons folder: e.g. brick.png
  • Add an image that does not override -and- sorts after the default filename: e.g. donkey.png
  • Run MultiMC
    No error.

With the working example, any number of extra images can be added to the /icons folder, so long as the first sorted filename is always a default icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant