Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main program entry point rework (configuration, arguments) #104

Open
ForNeVeR opened this issue May 28, 2023 · 0 comments
Open

Main program entry point rework (configuration, arguments) #104

ForNeVeR opened this issue May 28, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented May 28, 2023

  • Drop all the old resource extraction code from the Program.fs.
    • Leave the bmp extractors, though: they are still useful occasionally.
  • Game data path should no longer be passed via the command line.
  • Instead, an optional path to the configuration file should be accepted via an environment variable.
  • The configuration file should have a parameter with the game data directory, defaulting to the LocalAppData (or .cache or whatever it's on macOS).
  • We could also use a game-provided configuration file with defaults (i.e. distribute the default configuration with the game); just make sure to properly support the platform-dependent cached data path there, i.e. by introducing a %CACHE% placeholder.
  • After we did this, remove the launchSettings.json from .gitignore (it should no longer be required to pass any non-shareable parameters there).
@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 28, 2023
@ForNeVeR ForNeVeR mentioned this issue Jun 6, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant