From f72e4f532d9e5e70bbe176fa41aa3f990ae994d0 Mon Sep 17 00:00:00 2001
From: Fokko Driesprong <fokko@tabular.io>
Date: Tue, 13 Feb 2024 22:55:05 +0100
Subject: [PATCH] Test OSX build

---
 .github/workflows/python-release.yml | 6 +++---
 tests/utils/test_config.py           | 7 +++++++
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/python-release.yml b/.github/workflows/python-release.yml
index a499446d4e..578ff007e4 100644
--- a/.github/workflows/python-release.yml
+++ b/.github/workflows/python-release.yml
@@ -34,7 +34,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ ubuntu-22.04, windows-2022, macos-11 ]
+        os: [ macos-11, macos-12, macos-13, macos-14 ]
 
     steps:
       - uses: actions/checkout@v4
@@ -43,7 +43,7 @@ jobs:
 
       - uses: actions/setup-python@v5
         with:
-          python-version: '3.8'
+          python-version: '3.11'
 
       - name: Install poetry
         run: pip install poetry
@@ -82,5 +82,5 @@ jobs:
 
       - uses: actions/upload-artifact@v3
         with:
-          name: "release-${{ matrix.os }}"
+          name: "release-${{ github.event.inputs.version }}"
           path: ./wheelhouse/*
diff --git a/tests/utils/test_config.py b/tests/utils/test_config.py
index d694e15562..617a7cd6a1 100644
--- a/tests/utils/test_config.py
+++ b/tests/utils/test_config.py
@@ -41,6 +41,13 @@ def test_from_environment_variables_uppercase() -> None:
     assert Config().get_catalog_config("PRODUCTION") == {"uri": "https://service.io/api"}
 
 
+@mock.patch.dict(os.environ, {
+    "PYICEBERG_CATALOG__PRODUCTION__S3__REGION": "eu-north-1"
+})
+def test_from_environment_variables_uppercase() -> None:
+    assert Config().get_catalog_config("PRODUCTION") == {"uri": "https://service.io/api"}
+
+
 def test_from_configuration_files(tmp_path_factory: pytest.TempPathFactory) -> None:
     config_path = str(tmp_path_factory.mktemp("config"))
     with open(f"{config_path}/.pyiceberg.yaml", "w", encoding=UTF8) as file: