Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Feedback on 9_4 release #428

Open
dreeves4321 opened this issue Sep 5, 2018 · 2 comments
Open

[Design] Feedback on 9_4 release #428

dreeves4321 opened this issue Sep 5, 2018 · 2 comments

Comments

@dreeves4321
Copy link
Collaborator

BUGS

  • resizing screen does not rescale x axes of disease status or lab plots. Data gets lost and there’s no indication that it is lost.
  • @ icon is cut off
  • Placeholders are shown as “” in saved notes sometimes. I could not reliably reproduce the bug.
  • placeholders are permitted in bad locations, with the wrong contexts. This leads to the POC acting bizarrely. (e.g. after fracture.)
  • POC: all labels and values in status bar should be clickable, and should mouseover with pointer hand.
  • undo (command-z) has unexpected results. Undoing deletion does not reinstate the context.

Design

  • Disease status diagnosis line: dashed (10,6pt), stroke-width(1.5), grey
  • Disease status diagnosis label: label should be at top and slightly to the right of the dashed line
  • Labs graphs are too large.
  • Remove the word “filter” from the shortcuts tray.
  • Error messages are unfriendly
  • Follow the v14.8 color palette to improve accessibility

Functionalities

  • POC: cannot undo selections. Tapping on a selected item should deselect it.
  • Minimap should be scrollable
@gregquinn2001
Copy link
Contributor

Next meeting let's discuss:

  1. Placeholders are shown as "" in saved notes sometimes. I could not reliably reproduce the bug.
  2. Placeholders are permitted in bad locations, with the wrong contexts. This leads to the POC acting bizarrely. (e.g. after fracture)
  3. Error messages are unfriendly
  4. Minimap should be scrollable

@dreeves4321
Copy link
Collaborator Author

  1. I can't make it happen again either. Perhaps it was fixed in the very last update.

  2. In the context of Fracture, or no condition for that matter, you can still create a placeholder for "Disease Status" or "Toxicity". This makes the POC either behave bizarrely or give errors. Placeholders should only be allowed in the correct context (just like shortcuts).

  3. The error message above appears in all red and isn't understandable to regular users. Error messages should be friendly and be clear that something went wrong. The error message here blames the user and is only somewhat helpful: "No parent context to set values within. Create a context before using @condition".

  4. The minimap should respond to scrubbing, such as with the two-finger pan or with the scroll wheel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants