From d26a0721ebc5177f66bf7b6d21db6e7a9c9ad274 Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 21:09:52 +0100 Subject: [PATCH 01/12] find non-quiet --- cmake_admin/FindInstPatch.cmake | 8 ++++---- cmake_admin/FindSndFile.cmake | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/cmake_admin/FindInstPatch.cmake b/cmake_admin/FindInstPatch.cmake index e77504597..537ae6ac9 100644 --- a/cmake_admin/FindInstPatch.cmake +++ b/cmake_admin/FindInstPatch.cmake @@ -25,8 +25,8 @@ This will define the following variables: #]=======================================================================] # Use pkg-config if available -find_package(PkgConfig QUIET) -pkg_check_modules(PC_INSTPATCH QUIET libinstpatch-1.0) +find_package(PkgConfig) +pkg_check_modules(PC_INSTPATCH libinstpatch-1.0) # Find the headers and library find_path( @@ -59,10 +59,10 @@ else() if(NOT TARGET GLib2::gobject-2 OR NOT TARGET GLib2::gthread-2 OR NOT TARGET GLib2::glib-2) - find_package(GLib2 QUIET) + find_package(GLib2) endif() if(NOT TARGET SndFile::sndfile) - find_package(SndFile QUIET) + find_package(SndFile) endif() set(_instpatch_link_libraries "GLib2::gobject-2" "GLib2::gthread-2" "GLib2::glib-2" "SndFile::sndfile") diff --git a/cmake_admin/FindSndFile.cmake b/cmake_admin/FindSndFile.cmake index d77333ba0..eecba5254 100644 --- a/cmake_admin/FindSndFile.cmake +++ b/cmake_admin/FindSndFile.cmake @@ -39,8 +39,8 @@ For compatibility with upstream, the following variables are also set: #]=======================================================================] # Use pkg-config if available -find_package(PkgConfig QUIET) -pkg_check_modules(PC_SNDFILE QUIET sndfile) +find_package(PkgConfig) +pkg_check_modules(PC_SNDFILE sndfile) # Find the headers and libraries find_path( @@ -78,12 +78,12 @@ if(PC_SNDFILE_FOUND) endif() elseif(_sndfile_library) # sndfile may need any of these libraries - find_package(Ogg 1.3 QUIET) - find_package(Vorbis QUIET) - find_package(FLAC QUIET) - find_package(Opus QUIET) - find_package(mp3lame QUIET) - find_package(mpg123 QUIET) + find_package(Ogg 1.3) + find_package(Vorbis) + find_package(FLAC) + find_package(Opus) + find_package(mp3lame) + find_package(mpg123) if(NOT CMAKE_CROSSCOMPILING) include(CheckSourceRuns) From 3b7e40be9dd56b837a944cbc9a50b371d747a03a Mon Sep 17 00:00:00 2001 From: Tom M Date: Tue, 2 Jan 2024 21:14:40 +0100 Subject: [PATCH 02/12] cmake trace --- .azure/azure-pipelines-win.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.azure/azure-pipelines-win.yml b/.azure/azure-pipelines-win.yml index ff498d645..2ca1a2aa8 100644 --- a/.azure/azure-pipelines-win.yml +++ b/.azure/azure-pipelines-win.yml @@ -71,7 +71,7 @@ jobs: SET "PATH=d:\deps\bin;%PATH%" pkg-config --list-all mkdir build && cd build || exit -1 - cmake -Werror=dev -A $(platform) -T $(toolset) -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 -Dwindows-version=0x0501 .. || exit -1 + cmake --trace -Werror=dev -A $(platform) -T $(toolset) -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 -Dwindows-version=0x0501 .. || exit -1 cmake --build . --config Release --parallel 3 || exit -1 displayName: 'Compile fluidsynth' - script: | @@ -144,7 +144,7 @@ jobs: @ECHO ON SET "PATH=d:\deps\bin;%PATH%" mkdir build && cd build || exit -1 - cmake -Werror=dev -A x64 -T $(toolset) -DCMAKE_BUILD_TYPE=$(CMAKE_CONFIG) -DCMAKE_VERBOSE_MAKEFILE=1 $(CMAKE_FLAGS) -DNO_GUI=1 -Dwindows-version=0x0A00 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-readline=0 -Denable-sdl2=0 -Denable-libinstpatch=0 .. || exit -1 + cmake --trace -Werror=dev -A x64 -T $(toolset) -DCMAKE_BUILD_TYPE=$(CMAKE_CONFIG) -DCMAKE_VERBOSE_MAKEFILE=1 $(CMAKE_FLAGS) -DNO_GUI=1 -Dwindows-version=0x0A00 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-readline=0 -Denable-sdl2=0 -Denable-libinstpatch=0 .. || exit -1 cmake --build . --config $(CMAKE_CONFIG) --parallel 3 || exit -1 displayName: 'Compile fluidsynth' - script: | @@ -215,7 +215,7 @@ jobs: set PATH=%PATH:C:\Program Files\Git\usr\bin;=% pkg-config --list-all mkdir build && cd build || exit -1 - cmake -Werror=dev -G "MinGW Makefiles" -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) $(CMAKE_FLAGS) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 .. || exit -1 + cmake --trace -Werror=dev -G "MinGW Makefiles" -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) $(CMAKE_FLAGS) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 .. || exit -1 mingw32-make.exe -j3 all || exit -1 displayName: 'Compile fluidsynth' - script: | From aa6ef7f1381c4be32748e476dbba1b5a84984b22 Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 21:29:09 +0100 Subject: [PATCH 03/12] Fix find_library on windows --- cmake_admin/FindInstPatch.cmake | 2 +- cmake_admin/FindSndFile.cmake | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake_admin/FindInstPatch.cmake b/cmake_admin/FindInstPatch.cmake index 537ae6ac9..0f74e4d43 100644 --- a/cmake_admin/FindInstPatch.cmake +++ b/cmake_admin/FindInstPatch.cmake @@ -37,7 +37,7 @@ find_path( find_library( InstPatch_LIBRARY - NAMES "instpatch-1.0" + NAMES "instpatch-1.0" "instpatch-2" HINTS "${PC_INSTPATCH_LIBDIR}") # Get version from pkg-config or read the config header diff --git a/cmake_admin/FindSndFile.cmake b/cmake_admin/FindSndFile.cmake index eecba5254..540e9e442 100644 --- a/cmake_admin/FindSndFile.cmake +++ b/cmake_admin/FindSndFile.cmake @@ -50,7 +50,7 @@ find_path( find_library( _sndfile_library - NAMES "sndfile" + NAMES "sndfile" "sndfile-1" HINTS "${PC_SNDFILE_LIBDIR}") # Get version from pkg-config or read the config header From eedfd867fdba4a96234062883466e04f919622fb Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 21:39:51 +0100 Subject: [PATCH 04/12] Revert "cmake trace" This reverts commit 3b7e40be9dd56b837a944cbc9a50b371d747a03a. --- .azure/azure-pipelines-win.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.azure/azure-pipelines-win.yml b/.azure/azure-pipelines-win.yml index 2ca1a2aa8..ff498d645 100644 --- a/.azure/azure-pipelines-win.yml +++ b/.azure/azure-pipelines-win.yml @@ -71,7 +71,7 @@ jobs: SET "PATH=d:\deps\bin;%PATH%" pkg-config --list-all mkdir build && cd build || exit -1 - cmake --trace -Werror=dev -A $(platform) -T $(toolset) -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 -Dwindows-version=0x0501 .. || exit -1 + cmake -Werror=dev -A $(platform) -T $(toolset) -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 -Dwindows-version=0x0501 .. || exit -1 cmake --build . --config Release --parallel 3 || exit -1 displayName: 'Compile fluidsynth' - script: | @@ -144,7 +144,7 @@ jobs: @ECHO ON SET "PATH=d:\deps\bin;%PATH%" mkdir build && cd build || exit -1 - cmake --trace -Werror=dev -A x64 -T $(toolset) -DCMAKE_BUILD_TYPE=$(CMAKE_CONFIG) -DCMAKE_VERBOSE_MAKEFILE=1 $(CMAKE_FLAGS) -DNO_GUI=1 -Dwindows-version=0x0A00 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-readline=0 -Denable-sdl2=0 -Denable-libinstpatch=0 .. || exit -1 + cmake -Werror=dev -A x64 -T $(toolset) -DCMAKE_BUILD_TYPE=$(CMAKE_CONFIG) -DCMAKE_VERBOSE_MAKEFILE=1 $(CMAKE_FLAGS) -DNO_GUI=1 -Dwindows-version=0x0A00 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-readline=0 -Denable-sdl2=0 -Denable-libinstpatch=0 .. || exit -1 cmake --build . --config $(CMAKE_CONFIG) --parallel 3 || exit -1 displayName: 'Compile fluidsynth' - script: | @@ -215,7 +215,7 @@ jobs: set PATH=%PATH:C:\Program Files\Git\usr\bin;=% pkg-config --list-all mkdir build && cd build || exit -1 - cmake --trace -Werror=dev -G "MinGW Makefiles" -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) $(CMAKE_FLAGS) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 .. || exit -1 + cmake -Werror=dev -G "MinGW Makefiles" -DCMAKE_INSTALL_PREFIX=$(Build.ArtifactStagingDirectory) $(CMAKE_FLAGS) -Denable-readline=0 -Denable-floats=1 -Denable-jack=0 -Denable-pulseaudio=0 -Denable-ladspa=0 -Denable-dbus=0 -Denable-sdl2=0 -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE=1 -DNO_GUI=1 .. || exit -1 mingw32-make.exe -j3 all || exit -1 displayName: 'Compile fluidsynth' - script: | From 4e2bf8b11a458b3abdc1d2fcb2699c32e9e7b3eb Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 22:39:31 +0100 Subject: [PATCH 05/12] Remove problematic include --- src/CMakeLists.txt | 4 ---- src/fluidsynth.c | 3 --- 2 files changed, 7 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 9a1f914f3..808b8b8f8 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -499,10 +499,6 @@ if ( TARGET PipeWire::PipeWire AND PIPEWIRE_SUPPORT ) # because pw_init() etc. target_link_libraries ( fluidsynth PRIVATE PipeWire::PipeWire ) endif() -if ( TARGET InstPatch::libinstpatch AND LIBINSTPATCH_SUPPORT ) - target_link_libraries ( fluidsynth PRIVATE InstPatch::libinstpatch ) -endif() - if ( TARGET LASH::LASH AND LASH_SUPPORT ) target_link_libraries ( fluidsynth PRIVATE LASH::LASH ) endif() diff --git a/src/fluidsynth.c b/src/fluidsynth.c index 2352f0db8..4ed19163f 100644 --- a/src/fluidsynth.c +++ b/src/fluidsynth.c @@ -29,9 +29,6 @@ #define GETOPT_SUPPORT 1 #endif -#ifdef LIBINSTPATCH_SUPPORT -#include -#endif #include "fluid_lash.h" #ifdef SYSTEMD_SUPPORT From f74c6b88d8a062e69d1671ea9cb80dbf66a79a4c Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 22:45:32 +0100 Subject: [PATCH 06/12] debug vars --- cmake_admin/FindInstPatch.cmake | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmake_admin/FindInstPatch.cmake b/cmake_admin/FindInstPatch.cmake index 0f74e4d43..d679a92ed 100644 --- a/cmake_admin/FindInstPatch.cmake +++ b/cmake_admin/FindInstPatch.cmake @@ -68,6 +68,10 @@ else() "GLib2::glib-2" "SndFile::sndfile") endif() +message(STATUS "PC_INSTPATCH_FOUND: ${PC_INSTPATCH_FOUND}") +message(STATUS "_instpatch_link_libraries: ${_instpatch_link_libraries}") +message(STATUS "SNDFILE_INCLUDE_DIR: ${SNDFILE_INCLUDE_DIR}") + # Forward the result to CMake include(FindPackageHandleStandardArgs) find_package_handle_standard_args( From 39cd749e0b6a17005e138cc4c61eb28971aa045d Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 23:02:32 +0100 Subject: [PATCH 07/12] Revert "debug vars" This reverts commit f74c6b88d8a062e69d1671ea9cb80dbf66a79a4c. --- cmake_admin/FindInstPatch.cmake | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cmake_admin/FindInstPatch.cmake b/cmake_admin/FindInstPatch.cmake index d679a92ed..0f74e4d43 100644 --- a/cmake_admin/FindInstPatch.cmake +++ b/cmake_admin/FindInstPatch.cmake @@ -68,10 +68,6 @@ else() "GLib2::glib-2" "SndFile::sndfile") endif() -message(STATUS "PC_INSTPATCH_FOUND: ${PC_INSTPATCH_FOUND}") -message(STATUS "_instpatch_link_libraries: ${_instpatch_link_libraries}") -message(STATUS "SNDFILE_INCLUDE_DIR: ${SNDFILE_INCLUDE_DIR}") - # Forward the result to CMake include(FindPackageHandleStandardArgs) find_package_handle_standard_args( From ce63e98b925de0e884fd88b2ddfeeecc6336eac2 Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 23:02:34 +0100 Subject: [PATCH 08/12] Revert "find non-quiet" This reverts commit d26a0721ebc5177f66bf7b6d21db6e7a9c9ad274. --- cmake_admin/FindInstPatch.cmake | 8 ++++---- cmake_admin/FindSndFile.cmake | 16 ++++++++-------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/cmake_admin/FindInstPatch.cmake b/cmake_admin/FindInstPatch.cmake index 0f74e4d43..112892651 100644 --- a/cmake_admin/FindInstPatch.cmake +++ b/cmake_admin/FindInstPatch.cmake @@ -25,8 +25,8 @@ This will define the following variables: #]=======================================================================] # Use pkg-config if available -find_package(PkgConfig) -pkg_check_modules(PC_INSTPATCH libinstpatch-1.0) +find_package(PkgConfig QUIET) +pkg_check_modules(PC_INSTPATCH QUIET libinstpatch-1.0) # Find the headers and library find_path( @@ -59,10 +59,10 @@ else() if(NOT TARGET GLib2::gobject-2 OR NOT TARGET GLib2::gthread-2 OR NOT TARGET GLib2::glib-2) - find_package(GLib2) + find_package(GLib2 QUIET) endif() if(NOT TARGET SndFile::sndfile) - find_package(SndFile) + find_package(SndFile QUIET) endif() set(_instpatch_link_libraries "GLib2::gobject-2" "GLib2::gthread-2" "GLib2::glib-2" "SndFile::sndfile") diff --git a/cmake_admin/FindSndFile.cmake b/cmake_admin/FindSndFile.cmake index 540e9e442..f610d9fcf 100644 --- a/cmake_admin/FindSndFile.cmake +++ b/cmake_admin/FindSndFile.cmake @@ -39,8 +39,8 @@ For compatibility with upstream, the following variables are also set: #]=======================================================================] # Use pkg-config if available -find_package(PkgConfig) -pkg_check_modules(PC_SNDFILE sndfile) +find_package(PkgConfig QUIET) +pkg_check_modules(PC_SNDFILE QUIET sndfile) # Find the headers and libraries find_path( @@ -78,12 +78,12 @@ if(PC_SNDFILE_FOUND) endif() elseif(_sndfile_library) # sndfile may need any of these libraries - find_package(Ogg 1.3) - find_package(Vorbis) - find_package(FLAC) - find_package(Opus) - find_package(mp3lame) - find_package(mpg123) + find_package(Ogg 1.3 QUIET) + find_package(Vorbis QUIET) + find_package(FLAC QUIET) + find_package(Opus QUIET) + find_package(mp3lame QUIET) + find_package(mpg123 QUIET) if(NOT CMAKE_CROSSCOMPILING) include(CheckSourceRuns) From 3b6c176e4ec9cd122b7ce605935d507fde7e99fd Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 23:11:23 +0100 Subject: [PATCH 09/12] try restore sf3 support?? --- cmake_admin/FindSndFile.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmake_admin/FindSndFile.cmake b/cmake_admin/FindSndFile.cmake index f610d9fcf..271bb061f 100644 --- a/cmake_admin/FindSndFile.cmake +++ b/cmake_admin/FindSndFile.cmake @@ -69,7 +69,8 @@ elseif(SndFile_INCLUDE_DIR) endif() # Check the features SndFile was built with -if(PC_SNDFILE_FOUND) +# 2024-01-02: Recent versions of libsndfile don't seem to provide a pkgconfig file and older version who did are lacking private libraries like OGG. +if(FALSE) #PC_SNDFILE_FOUND if("vorbis" IN_LIST PC_SNDFILE_STATIC_LIBRARIES) set(SndFile_WITH_EXTERNAL_LIBS TRUE) endif() From 0d15ff691bf3a080dd8518832752fd7f9561097b Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 23:24:58 +0100 Subject: [PATCH 10/12] investigate opus error on mac ci --- cmake_admin/FindOpus.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmake_admin/FindOpus.cmake b/cmake_admin/FindOpus.cmake index 0258d4561..b31faffc5 100644 --- a/cmake_admin/FindOpus.cmake +++ b/cmake_admin/FindOpus.cmake @@ -37,8 +37,8 @@ For compatibility with upstream, the following variables are also set: #]=======================================================================] # Use pkg-config if available -find_package(PkgConfig QUIET) -pkg_check_modules(PC_OPUS QUIET opus) +find_package(PkgConfig) +pkg_check_modules(PC_OPUS opus) # Find the headers and library find_path( From 5bd8b4de6df73137acc2234072ab828ab8f57503 Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 23:44:15 +0100 Subject: [PATCH 11/12] Fix index out of range --- cmake_admin/FindOpus.cmake | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmake_admin/FindOpus.cmake b/cmake_admin/FindOpus.cmake index b31faffc5..bf77e293b 100644 --- a/cmake_admin/FindOpus.cmake +++ b/cmake_admin/FindOpus.cmake @@ -37,8 +37,8 @@ For compatibility with upstream, the following variables are also set: #]=======================================================================] # Use pkg-config if available -find_package(PkgConfig) -pkg_check_modules(PC_OPUS opus) +find_package(PkgConfig QUIET) +pkg_check_modules(PC_OPUS QUIET opus) # Find the headers and library find_path( @@ -53,13 +53,13 @@ find_library( # Get the version from pkg-config if(PC_OPUS_VERSION) - set(Opus_VERSION "${PC_OPUS_VERSION}") + set(Opus_VERSION "${PC_OPUS_VERSION}.0") set(OPUS_VERSION "${Opus_VERSION}") set(OPUS_VERSION_STRING "${Opus_VERSION}") string(REPLACE "." ";" _opus_version_list "${Opus_VERSION}") list(GET _opus_version_list 0 OPUS_VERSION_MAJOR) list(GET _opus_version_list 1 OPUS_VERSION_MINOR) - list(GET _opus_version_list 2 OPUS_VERSION_PATCH) + list(GET _opus_version_list 2 OPUS_VERSION_PATCH) # might be missing if zero, hence adding the .0 above else() message(STATUS "Unable to get Opus version without pkg-config.") set(Opus_VERSION) From 94ad96e0eac2ed38f2b38754e375f311326cafd2 Mon Sep 17 00:00:00 2001 From: derselbst Date: Tue, 2 Jan 2024 23:55:52 +0100 Subject: [PATCH 12/12] Fix 'The target name MPG123::libmpg123 is reserved or not valid' --- cmake_admin/Findmpg123.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake_admin/Findmpg123.cmake b/cmake_admin/Findmpg123.cmake index 76e041275..3cb351679 100644 --- a/cmake_admin/Findmpg123.cmake +++ b/cmake_admin/Findmpg123.cmake @@ -92,7 +92,7 @@ find_package_handle_standard_args( # Create the targets foreach(_component libmpg123 libout123 libsyn123) if(mpg123_${_component}_FOUND AND NOT TARGET MPG123::${_component}) - add_library(MPG123::${_component}) + add_library(MPG123::${_component} UNKNOWN IMPORTED) set_target_properties( MPG123::${_component} PROPERTIES IMPORTED_LOCATION "${mpg123_${_component}_LIBRARY}"