Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update launcher to work in dev-env following org rename #190

Closed
Steve-Mcl opened this issue Nov 15, 2023 · 0 comments · Fixed by #191
Closed

Update launcher to work in dev-env following org rename #190

Steve-Mcl opened this issue Nov 15, 2023 · 0 comments · Fixed by #191
Labels
size:XS - 1 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.

Comments

@Steve-Mcl
Copy link
Contributor

Description

lib/launcher.js Line 352 still refers to flowforge-driver-localfs

nr-launcher/lib/launcher.js

Line 352 in c2843b9

const devEnvPath = path.join(require.main.path, '..', 'flowforge-driver-localfs', 'node_modules')

This should be 'driver-localfs'

This prevents the running of instances in our development environment,

Epic/Story

No response
@Steve-Mcl Steve-Mcl added task A piece of work that isn't necessarily tied to a specific Epic or Story. size:XS - 1 Sizing estimation point labels Nov 15, 2023
Steve-Mcl added a commit that referenced this issue Nov 15, 2023
@Steve-Mcl
updated path to localfs for org rename
e7c9b11 
fixes #190
@Steve-Mcl Steve-Mcl mentioned this issue Nov 15, 2023
Merged
@Steve-Mcl Steve-Mcl linked a pull request Nov 15, 2023 that will close this issue
Update path to localfs following org rename #191
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
size:XS - 1 Sizing estimation point task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
☁️ Product Planning
Status: Closed / Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update path to localfs following org rename FlowFuse/nr-launcher
1 participant
@Steve-Mcl