Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch with custom icon - clickable entire line #1522

Closed
egs2003 opened this issue Dec 7, 2024 · 2 comments
Closed

switch with custom icon - clickable entire line #1522

egs2003 opened this issue Dec 7, 2024 · 2 comments
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do

Comments

@egs2003
Copy link

egs2003 commented Dec 7, 2024

Current Behavior

if i click on the icon, nothing happens

Expected Behavior

click on line, icon or button should change the state

Steps To Reproduce

[
{
"id": "0e65c4d34d11de2e",
"type": "ui-switch",
"z": "34e4856b.14037a",
"name": "",
"label": "Baum",
"group": "f15f86f2136f3b9c",
"order": 1,
"width": "2",
"height": "1",
"passthru": false,
"decouple": false,
"topic": "topic",
"topicType": "msg",
"style": "",
"className": "",
"layout": "row-spread",
"clickableArea": "line",
"onvalue": "ON",
"onvalueType": "str",
"onicon": "pine-tree",
"oncolor": "#ff3",
"offvalue": "OFF",
"offvalueType": "str",
"officon": "pine-tree",
"offcolor": "#ccc8",
"x": 530,
"y": 3300,
"wires": [
[]
]
},
{
"id": "f15f86f2136f3b9c",
"type": "ui-group",
"name": "Group Name",
"page": "a9d73a1858594618",
"width": "6",
"height": "1",
"order": 1,
"showTitle": false,
"className": "group_switches",
"visible": "true",
"disabled": "false",
"groupType": "default"
},
{
"id": "a9d73a1858594618",
"type": "ui-page",
"name": "Home",
"ui": "f43bda2aa15343bf",
"path": "/page1",
"icon": "home",
"layout": "grid",
"theme": "e82cb4d5ab509d2d",
"breakpoints": [
{
"name": "Default",
"px": "0",
"cols": "3"
},
{
"name": "Tablet",
"px": "576",
"cols": "6"
},
{
"name": "Small Desktop",
"px": "768",
"cols": "9"
},
{
"name": "Desktop",
"px": "1024",
"cols": "12"
}
],
"order": 1,
"className": "",
"visible": "true",
"disabled": "false"
},
{
"id": "f43bda2aa15343bf",
"type": "ui-base",
"name": "test",
"path": "/dashboard",
"appIcon": "",
"includeClientData": true,
"acceptsClientConfig": [
"ui-notification",
"ui-control"
],
"showPathInSidebar": false,
"showPageTitle": false,
"navigationStyle": "icon",
"titleBarStyle": "default",
"showReconnectNotification": true,
"notificationDisplayTime": "1",
"showDisconnectNotification": true
},
{
"id": "e82cb4d5ab509d2d",
"type": "ui-theme",
"name": "Default Theme",
"colors": {
"surface": "#ffffff",
"primary": "#0094ce",
"bgPage": "#eeeeee",
"groupBg": "#ffffff",
"groupOutline": "#cccccc"
},
"sizes": {
"density": "default",
"pagePadding": "12px",
"groupGap": "12px",
"groupBorderRadius": "4px",
"widgetGap": "12px"
}
}
]

Environment

  • Dashboard version: 1.20.0
  • Node-RED version: 4.0.5
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser: chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@egs2003 egs2003 added bug Something isn't working needs-triage Needs looking at to decide what to do labels Dec 7, 2024
@bartbutenaers
Copy link
Contributor

Hi @egs2003,
Thanks for sharing a simple flow that allows us to reproduce the problem very easily. That really helps!

I have created a pull request to fix this:
#1523

@joepavitt
Copy link
Collaborator

Closed by #1523

@github-project-automation github-project-automation bot moved this from Backlog to Done in Dashboard Backlog Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage Needs looking at to decide what to do
Projects
Status: Done
Development

No branches or pull requests

3 participants