Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all template content is supported in dynamic use-case #1517

Open
joepavitt opened this issue Dec 6, 2024 · 6 comments
Open

Not all template content is supported in dynamic use-case #1517

joepavitt opened this issue Dec 6, 2024 · 6 comments
Labels
bug Something isn't working size:M - 3 Sizing estimation point

Comments

@joepavitt
Copy link
Collaborator

Current Behavior

Injecting some particular templates dynamically causes rendering issue for a ui-template.

This is a known issue with #1475, but the functionality introduced there improves the existing status-quo, so didn't think this issue would be a blocker.

Expected Behavior

Any injected template content should render the same as if it was rendered in the static configuration in the first place

Steps To Reproduce

See: #1475

Environment

  • Dashboard version:
  • Node-RED version:
  • Node.js version:
  • npm version:
  • Platform/OS:
  • Browser:

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@joepavitt joepavitt added bug Something isn't working needs-triage Needs looking at to decide what to do size:M - 3 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Dec 6, 2024
@bartbutenaers
Copy link
Contributor

@joepavitt ,
If you find some time, could you please add some more details here about what is going wrong.
It is not quite clear to me which problems you have.
Thanks!

@joepavitt
Copy link
Collaborator Author

@bartbutenaers specifically referring to #1475 (comment)

@joepavitt joepavitt mentioned this issue Dec 6, 2024
10 tasks
@bartbutenaers
Copy link
Contributor

What a pitty that I cannot reproduce the problem. Seems to be working fine here.
If you have any idea how I could reproduce it, please let me know so I can at least help investigating the issue.

@joepavitt
Copy link
Collaborator Author

Just to clarify (as I thought your comment suggested that you did reproduce it) - even if you switched to the Hello World example, and then back to the counter example ,you could click the counter and it'd show "X Apples"?

@bartbutenaers
Copy link
Contributor

@joepavitt ,
Ah ok, I think we have a misunderstanding. I thought that the template even didn't render for you, while it rendered for me fine. I wasn't aware that you couldn't click the button. So I was thinking out loud, in order to provide you some ideas that might help you to solve your issue.

But yes indeed after your last comment above, I can confirm that it renders fine but nothing happens when I click on the injected button. I will have a look, but no idea at the moment where to start searching.

@bartbutenaers
Copy link
Contributor

Have spend all evening debugging, but no luck. Frameworks live Vue are a bit too much of magic to me personally.

Not sure if this Stackoverflow solution could be of any help here.
But they include the runtime compiler in their frontend.
Including a compiler is not wanted here, because it also works fine with the template from the config screen.
So not sure where I should put the .bind(this) and whether it will help solving this reactivity issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M - 3 Sizing estimation point
Projects
Status: Backlog
Development

No branches or pull requests

2 participants