Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-table - Data is Always Replaced, Even if "Action" is "Append" #1407

Closed
jtempletmg opened this issue Oct 15, 2024 · 2 comments · Fixed by #1408
Closed

ui-table - Data is Always Replaced, Even if "Action" is "Append" #1407

jtempletmg opened this issue Oct 15, 2024 · 2 comments · Fixed by #1408
Assignees
Labels
bug Something isn't working priority:high High Priority size:S - 2 Sizing estimation point

Comments

@jtempletmg
Copy link

jtempletmg commented Oct 15, 2024

Current Behavior

Using ui-table on a dashboard, if the "Action" is set to "Append", the data in the table is always cleared.

Expected Behavior

Using "Action" "Append" should add any incoming data sets to the table.

Steps To Reproduce

  1. Add ui-table to a dashboard
  2. Set the "Action" to "Append"
  3. Trigger multiple data sets to the widget
  4. Only the last data set is visible

Note that this behavior persists until you toggle the "Action" to "Replace" then back to "Append". When the dashboard is deployed after toggling the "Action" the "Append" starts working.

Environment

  • Dashboard version: 1,18.1
  • Node-RED version: 4.0.5
  • Node.js version: 18.20.4
  • npm version: 10.7.0
  • Platform/OS: Raspbian Bullseye
  • Browser: Chrome

Have you provided an initial effort estimate for this issue?

I have provided an initial effort estimate

@jtempletmg jtempletmg added bug Something isn't working needs-triage Needs looking at to decide what to do labels Oct 15, 2024
@joepavitt joepavitt added priority:high High Priority size:S - 2 Sizing estimation point and removed needs-triage Needs looking at to decide what to do labels Oct 15, 2024
@joepavitt joepavitt moved this from Backlog to Up Next in Dashboard Backlog Oct 15, 2024
@jtempletmg
Copy link
Author

Additional comment on this: user on Discord noted that if the Action was toggled to "Replace" then back to "Append" and the deployed it does indeed start appending.

@gayanSandamal
Copy link
Contributor

gayanSandamal commented Oct 16, 2024

@joepavitt I did couple of testings on my local instance but I couldn't recreate it

Screen.Recording.2024-10-16.at.10.36.33.mov

But when I did the same on the dashboard demos instance I could recreate the scenario https://dashboard-demos-dev.flowfuse.cloud/dashboard/table-1

Assuming the root cause is with setting the default in ui_table.js I've created a PR with the fix

#1408

@github-project-automation github-project-automation bot moved this from Under Review to Done in Dashboard Backlog Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high High Priority size:S - 2 Sizing estimation point
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants