Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic html needs to be sanetized #1387

Closed
bartbutenaers opened this issue Oct 12, 2024 · 2 comments
Closed

Dynamic html needs to be sanetized #1387

bartbutenaers opened this issue Oct 12, 2024 · 2 comments
Labels
priority:high High Priority size:S - 2 Sizing estimation point

Comments

@bartbutenaers
Copy link
Contributor

Hi guys,

Our friend @dceejay has reviewed my pull-request for html labels. He correctly mentioned that I needed to sanetize the html. While implementing a fix, I saw that the same problem does exist in many other places.

The dom-purify library is currently only used for the v-html in the ui-markdown node. But not for the v-html attribute in the following files:

Not sure whether all of these might impose a security risk, but I assume it is better to have a look at all of them.

If you want I can have a look at this...

Bart

@m-schaeffler
Copy link
Contributor

👍

@joepavitt joepavitt added size:S - 2 Sizing estimation point priority:high High Priority labels Oct 12, 2024
@joepavitt joepavitt moved this from Backlog to Up Next in Dashboard Backlog Oct 12, 2024
@bartbutenaers
Copy link
Contributor Author

This has been implemented for all widgets. The remaining ones where about the documentation, but that seems not to be a security risk (see PR conversation). So for me this issue is completed.

@github-project-automation github-project-automation bot moved this from Up Next to Done in Dashboard Backlog Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High Priority size:S - 2 Sizing estimation point
Projects
Status: Done
Development

No branches or pull requests

3 participants