Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable PWA Icon #1328

Closed
Tracked by #1144
joepavitt opened this issue Sep 25, 2024 · 4 comments · Fixed by #1366
Closed
Tracked by #1144

Configurable PWA Icon #1328

joepavitt opened this issue Sep 25, 2024 · 4 comments · Fixed by #1366
Assignees
Labels
size:M - 3 Sizing estimation point

Comments

@joepavitt
Copy link
Collaborator

joepavitt commented Sep 25, 2024

Given #1326, the configured icon shows when Dashboard is installed locally to a mobile device or laptop.

Configuring PWA

  1. Open Browser on Mobile
  2. Navigate to ipaddress:port/dashboard
  3. Settings > Install (Exact phrasing depends on which phone you've got)
@gayanSandamal
Copy link
Contributor

@joepavitt

I’ve tried making the PWA icon dynamic, but unfortunately, it's not something that can be set at runtime like a favicon. PWA icons must be specified at build time, and they only support files in the local directory. External image URLs are not supported.

Also I've this way which was mentioned in the main issue #1144

We’ll need to generate the icons during the build process and ensure they’re bundled within the application.

@joepavitt
Copy link
Collaborator Author

What happened to the option of serving up manifest file via the Express server? e.g. https://stackoverflow.com/questions/50086761/dynamic-icon-pwa-manifest

@joepavitt
Copy link
Collaborator Author

Yes, it would need to be a local file, but I think that's still an option here, as we can upload local files to Node-RED?

@gayanSandamal
Copy link
Contributor

What happened to the option of serving up manifest file via the Express server? e.g. https://stackoverflow.com/questions/50086761/dynamic-icon-pwa-manifest

This works when we have the icons in the public directory itself.

Yes, it would need to be a local file, but I think that's still an option here, as we can upload local files to Node-RED?

I will try in this way as well

@gayanSandamal gayanSandamal linked a pull request Oct 7, 2024 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from Under Review to Done in Dashboard Backlog Oct 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🛠 Development Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M - 3 Sizing estimation point
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants