-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper re-try behavior based 408, 400 and 503 errors and other responses #18
Comments
In last days also http 502 and 504 (error) messages where received, also handle these? |
I believe we should mention that this will re-try until a schedule is ready. Actually, I'm not so sure this works as expected, as we seem to poll only on failure (408, 503), not on responses that tell us that the results are not ready - I believe those are coded as 400 right now. @Flix6x should this be resolved in another issue, also in the flexmeasures server? Originally posted by @nhoening in #28 (comment) |
To be cleaer - It seems to me that 400 is the wrong code, so FlexMeasures server might require an issue, as well. |
Note that the docstring here does not reflect the actual code here. The actual code does check whether the scheduling job is waiting or in progress, so for now we have that covered. Related issue: FlexMeasures/flexmeasures#645 |
In the
request
docstring it mentions 408 explicitly. I think we should check for that here explicitly. Note that in the one test we have in which the server responds with a 408, the client actually gives up before the server sends something back.Originally posted by @Flix6x in #7 (comment)
The text was updated successfully, but these errors were encountered: