Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGTM Achievement or addition to "Vital Contributor" #16

Open
doyler opened this issue Jul 6, 2023 · 3 comments
Open

LGTM Achievement or addition to "Vital Contributor" #16

doyler opened this issue Jul 6, 2023 · 3 comments

Comments

@doyler
Copy link

doyler commented Jul 6, 2023

There is currently no achievement for 100 issue comments stating "LGTM".

This should either have its own achievement or be added as an alternative path for obtaining the "Vital Contributor" achievement.

@Flet
Copy link
Owner

Flet commented Jul 6, 2023

Ohh, I like this idea.

@Flet
Copy link
Owner

Flet commented Jul 7, 2023

I think this should be combined with #11 and maybe as

"The Auditor - Comment LGTM on 100 pull requests within 1 minute of opening."

@burdges
Copy link

burdges commented Jul 9, 2023

1 minute is extremely fast, but also 100 is not so many. I'd say:

Vital Contributor - Participated in over 100 issues or PRs with just a "+1" or a thumbs up emoji, or only a "LGTM".

Around this, speed reader feels way too hard to achieve:

Speed Reader - Review and approve a pull request that contains over 10,000 lines of code in under 5 minutes.

I think The Auditor is a great name, but it should be differentiated from Speed Reader somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants