fixes for latest @flatfile/api release #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangarang
approved these changes
Mar 27, 2024
carlbrugger
changed the title
bangarang
reviewed
Mar 28, 2024
| @@ -22,7 +22,7 @@ function commonPlugins(browser, umd = false) { | |||
| json(), | |||
| commonjs({ | |||
| include: '**/node_modules/**', | |||
| requireReturnsDefault: 'preferred', | |||
| requireReturnsDefault: 'auto', | |||
There was a problem hiding this comment.
We should make a shared Rollup config so that 1 change doesn't hit every package!
There was a problem hiding this comment.
I like the idea of drying the Rollup config, but don't we want it to hit every package to trigger changset?
bangarang
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain how to summarize this PR for the Changelog:
@flatfile/plugin-connect-via-merge:@flatfile/[email protected]removescountRecordsfrom the get sheet endpoint. This release switches to the get record count endpoint.This release also includes bundling fixes across the Flatfile plugin ecosystem.
Tell code reviewer how and what to test: