Skip to content

Commit

Permalink
fixes dataRowAndSubHeaderDetection algorithm (#687)
Browse files Browse the repository at this point in the history
* fixes dataRowAndSubHeaderDetection algorithm

* coderabbitai suggestion
  • Loading branch information
carlbrugger authored Oct 30, 2024
1 parent 3c02db1 commit 615542b
Show file tree
Hide file tree
Showing 8 changed files with 216 additions and 314 deletions.
10 changes: 10 additions & 0 deletions .changeset/red-cows-appear.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@flatfile/plugin-delimiter-extractor': patch
'@flatfile/plugin-xlsx-extractor': patch
'@flatfile/plugin-convert-json-schema': patch
'@flatfile/plugin-export-pivot-table': patch
'@flatfile/plugin-rollout': patch
'@flatfile/util-extractor': patch
---

This release fixes misc bugs
4 changes: 3 additions & 1 deletion export/pivot-table/src/pivot.table.plugin.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import api from '@flatfile/api'
import { FlatfileClient } from '@flatfile/api'
import { FlatfileEvent, FlatfileListener } from '@flatfile/listener'
import {
convertPivotTableToMarkdown,
generatePivotTable,
} from './pivot.table.utils'

const api = new FlatfileClient()

/**
* Configuration interface for the Pivot Table plugin
*/
Expand Down
112 changes: 6 additions & 106 deletions flatfilers/sandbox/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,113 +1,13 @@
import api, { type Flatfile } from '@flatfile/api'
import type { FlatfileListener } from '@flatfile/listener'
import {
type PartialSheetConfig,
type PartialWorkbookConfig,
configureSpaceWithJsonSchema,
fetchExternalReference,
} from '@flatfile/plugin-convert-json-schema'
import { ExcelExtractor } from '@flatfile/plugin-xlsx-extractor'

export default function (listener: FlatfileListener) {
const workbookActions: Flatfile.Action[] = [
{
operation: 'submitAction',
mode: 'foreground',
label: 'Submit data',
type: 'string',
description: 'Submit this data to a webhook.',
primary: true,
},
]

const sheetActions: Flatfile.Action[] = [
{
operation: 'duplicateSheet',
mode: 'foreground',
label: 'Duplicate',
description: 'Duplicate this sheet.',
primary: true,
},
]

const personModel: PartialSheetConfig = {
source: {
$id: 'https://raw.githubusercontent.com/FlatFilers/flatfile-docs-kitchen-sink/main/typescript/dynamic-configurations-json-schema/example-schemas/person.json',
$schema: 'https://json-schema.org/draft/2020-12/schema',
title: 'Person',
type: 'object',
properties: {
firstName: {
type: 'string',
description: "The person's first name.",
},
lastName: {
type: 'string',
description: "The person's last name.",
},
age: {
description:
'Age in years which must be equal to or greater than zero.',
type: 'integer',
minimum: 0,
},
},
},
slug: 'person',
name: 'Person',
actions: sheetActions,
}

const customerModel: PartialSheetConfig = {
source:
'https://raw.githubusercontent.com/FlatFilers/flatfile-docs-kitchen-sink/main/typescript/dynamic-configurations-json-schema/example-schemas/customer.json',
slug: 'customer',
name: 'Customer',
actions: sheetActions,
}

const productModel: PartialSheetConfig = {
source: () =>
fetchExternalReference(
'https://raw.githubusercontent.com/FlatFilers/flatfile-docs-kitchen-sink/main/typescript/dynamic-configurations-json-schema/example-schemas/product.json'
),
slug: 'product',
name: 'Product',
actions: sheetActions,
}

const workbookOne: PartialWorkbookConfig = {
name: 'Store Workbook',
sheets: [customerModel, productModel],
actions: workbookActions,
}

const workbookTwo: PartialWorkbookConfig = {
name: 'Person Workbook',
sheets: [personModel],
actions: workbookActions,
}

const callback = async (event, workbookIds, tick) => {
const { spaceId } = event.context
await api.documents.create(spaceId, {
title: 'Welcome',
body: `<div>
<h1>Welcome!</h1>
<h2>To get started, follow these steps:</h2>
<h2>1. Step One</h2>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.</p>
<h3>Remember, if you need any assistance, you can always refer back to this page by clicking "Welcome" in the left-hand sidebar!</h3>
</div>`,
})
await tick(80, 'Document created')
}

listener.use(
configureSpaceWithJsonSchema(
{
workbooks: [workbookOne, workbookTwo],
ExcelExtractor({
headerDetectionOptions: {
algorithm: 'dataRowAndSubHeaderDetection',
rowsToSearch: 20,
},
callback
)
})
)
}
Loading

0 comments on commit 615542b

Please sign in to comment.