Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any model properties without docblocks can cause a crash during testing #26

Open
Firehed opened this issue Jun 30, 2021 · 1 comment
Open

Any model properties without docblocks can cause a crash during testing #26

Firehed opened this issue Jun 30, 2021 · 1 comment

Comments

@Firehed
Copy link
Owner

Firehed commented Jun 30, 2021

There are currently assertions for doc comments being non-false, which on any unmapped/uncommented properties will trigger an assertion failure. These should, instead, probably be replaced with a continue in the loops where these checks occur, to ignore any unmapped properties.

Any implementation should be cautious about native annotation support when it's added.
@Firehed
Copy link
Owner Author

Firehed commented Aug 5, 2021

This is probably fixed by #29, but for the moment I'll leave this open until I can verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Firehed