Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains without HTTP/HTTPS prefix not processing correctly #1

Open
aFinchy opened this issue Apr 16, 2024 · 1 comment
Open

Domains without HTTP/HTTPS prefix not processing correctly #1

aFinchy opened this issue Apr 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@aFinchy
Copy link
Member

aFinchy commented Apr 16, 2024

Description

When domains are entered without an "http://" or "https://" prefix, they are not being processed correctly. This issue affects the URL normalization process, causing failures in subsequent operations that depend on properly formatted URLs.

Steps to Reproduce

  1. Input a URL without a scheme into the system (e.g., example.com or www.example.com).
  2. Observe that the URL does not get correctly prefixed with "http://", leading to failures in processing.

Expected Behavior

Domains entered without an HTTP/HTTPS prefix should automatically have "http://" appended to ensure they are processed correctly throughout the system.

Actual Behavior

The domains are left without any scheme, which leads to incorrect processing and potential errors in downstream functionality.

Possible Solution

Adjust the URL normalization function to detect and prepend "http://" to URLs lacking a scheme.

This issue is critical for ensuring all user-entered URLs are handled uniformly and correctly across the platform.

@aFinchy aFinchy added the bug Something isn't working label Apr 16, 2024
@aFinchy
Copy link
Member Author

aFinchy commented Apr 16, 2024

After some testing, it appears that it works with www.domain.com, but when you do www.sub.domain.com it does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant