-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readiness logic cannot access APIs when custom allowed origins are set #702
Comments
…ess-apis-when-custom-allowed-origins-are-set fix(#702): Readiness logic cannot access APIs when custom allowed origins are set
…ess-apis-when-custom-allowed-origins-are-set test(#702): readiness with custom origins tests
…orrect implementation, removed option to specify custom allowed origins
…ess-apis-when-custom-allowed-origins-are-set fix(#702): reimplemented CORS filter and preflight handler for more correct implementation, removed option to specify custom allowed origins
After lots of discussion, we've come to conclusion that custom allowed origins will no longer be supported by evita, instead
Also the |
When an API has custom
allowedOrigins
list defined in configuration, the internal readiness logic cannot access the API, becauseCorsFilter
cancels the request because the readiness logic doesn't send any origin header, thus it is not allowed.We need to send origin header from the readiness logic if any allowed origin is specified.
The text was updated successfully, but these errors were encountered: