Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: merge messages #84

Open
CanopusFalling opened this issue Mar 24, 2021 · 5 comments
Open

stats: merge messages #84

CanopusFalling opened this issue Mar 24, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@CanopusFalling
Copy link

Modification to the $channelSummary command that lets the user merge messages so that multiple messages over a short period of time show up as a single single message so text spam influences the stats less.

This could be done using a flag on the command or just a new command, honestly I don't know what's possible.

@WilliamWFLee
Copy link
Collaborator

I think what needs to be determined is what this "short of period of time" is, if it's fixed, or if we give users of the command the choice of this time period. Also, should users be given the choice between a "raw" or "corrected" channel summary?

@WilliamWFLee WilliamWFLee added the enhancement New feature or request label Mar 25, 2021
@CanopusFalling
Copy link
Author

I think what needs to be determined is what this "short of period of time" is, if it's fixed, or if we give users of the command the choice of this time period.

I was thinking of giving users a choice of the time set with a default time of 2 minutes if no arguments are given. For example $channelSummary --merge-messages 60 where the 60 is in seconds. And if no argument is given it would default to 120.

Also, should users be given the choice between a "raw" or "corrected" channel summary?

I assume you're referring to the default nature of the $channelSummary command, I assumed this would stay the same.

I'm open to suggestions on this either way though, am not entirely sure what would work best and be easiest to implement.

@WilliamWFLee
Copy link
Collaborator

AFAIK, discord.py doesn't have in-built functionality for command flags, only command parameters. There's two packages that extend the discord namespace to allow flags, but neither of them are particularly well-maintained, and it's not clear how well they slot in with discord.py itself.

I think it seems like a sensible idea to keep the default behaviour of $channelSummary, but it depends how this flag business goes.

@CanopusFalling
Copy link
Author

Fair, in that case it may be a new command.

I'll give experimenting with the flags a go when possible but it's probably best not to add a package for something like that.

Thanks for the advice! :)

@WilliamWFLee
Copy link
Collaborator

No problem. The most well-maintained flag utility package is this one: https://github.com/XuaTheGrate/Flag-Parsing if you decide to go ahead with flags.

When you decide to get started on implementation, let us if you have any questions about how to structure your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants