Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the setCriticalPoint() return a boolean? #7

Open
annamannucci opened this issue Mar 18, 2021 · 1 comment
Open

Should the setCriticalPoint() return a boolean? #7

annamannucci opened this issue Mar 18, 2021 · 1 comment

Comments

@annamannucci
Copy link
Collaborator

It may happen that the tracker cannot update the current critical point due to delays in communication. The current architecture is not robust to such types of faults. How to deal with them?

@FedericoPecora
Copy link
Owner

setCriticalPoint() returning a boolean is an option, but not a very robust one since it assumes that you know that the message has not been received. A more robust way is to check in the next RobotReport (after invoking setCriticalPoint(), that is) to see if the currently known CP is the one that you wanted to set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants